Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Zombienet: paritydb test #5310

Merged
merged 18 commits into from
Jul 18, 2022
Merged

Zombienet: paritydb test #5310

merged 18 commits into from
Jul 18, 2022

Conversation

sandreim
Copy link
Contributor

Resolves #4952

@sandreim
Add test
b71bd6e 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
gitlab integration
73c9ca0 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim requested a review from a team as a code owner April 12, 2022 09:22
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 12, 2022
@sandreim sandreim requested review from ordian and drahnr April 12, 2022 09:23
@sandreim sandreim added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 12, 2022
ordian
ordian approved these changes Apr 12, 2022
View reviewed changes
zombienet_tests/misc/0001-paritydb.feature Outdated Show resolved Hide resolved
@sandreim
tune test
27e149a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
fix
815814c 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Try waiting for nodes to be up before checks
1660c19 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim mentioned this pull request Jun 23, 2022
Closed
@sandreim
Copy link
Contributor Author

Alternative solution would be to check the pod node disk storage after launching the zombienode. We can easily see what DB is being used by parachains.

├── db
│   └── parachains
│       └── db
├── keystore
├── network
└── paritydb
    ├── full
    └── parachains

@sandreim
Use js check for paritydb folder
d28774a 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
9545fb9 
…/zombienet_parity_db_test
@sandreim
artifacts true
c313748 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim sandreim removed the request for review from a team June 23, 2022 13:05
@paritytech-ci paritytech-ci requested a review from a team June 23, 2022 13:05
@sandreim
change error message
dcc3cb7 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
debug
b2d0fdc 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
try again
a7fa060 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
pepoviola
pepoviola reviewed Jun 24, 2022
View reviewed changes
zombienet_tests/misc/0001-check_paritydb.js Outdated

const { exec } = require("child_process");

exec(`ls -lahR /data`, (error, stdout, stderr) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandreim, this will not works since the custom-js script will be ran in the pod that run zombienet and not in the nodes. I can add the feature to run commands in the pods through kubectl/podman as a new feature to validate this.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I made this assumption after so much local testing where this made sense. I think it would be helpful to have the ability to run commands inside the pod. Makes testing rely on more than just metrics and logs. We could also run a CPU profiler for example using this same interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paritytech/zombienet#246

@paritytech-ci paritytech-ci requested a review from a team June 29, 2022 15:39
@chevdor
Copy link
Contributor

chevdor commented Jun 29, 2022

cc @EgorPopelyaev

sandreim and others added 2 commits June 30, 2022 10:14
@pepoviola
Copy link
Contributor

Hi @sandreim, I changed the js script for a bash script that can now be ran inside of the containers with the syntax

nodeName: run ./bash-script.sh [with "arg1,arg2...."] [within x seconds]

This will be uploaded to the container and the execute by zombienet.

Thanks!

chevdor
chevdor approved these changes Jul 14, 2022
View reviewed changes
zombienet_tests/misc/0001-check_paritydb.sh Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 14, 2022 07:23
@pepoviola @chevdor
Update zombienet_tests/misc/0001-check_paritydb.sh
b673621 
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@sandreim
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit eed45cf into master Jul 18, 2022
@paritytech-processbot paritytech-processbot bot deleted the sandreim/zombienet_parity_db_test branch July 18, 2022 10:55
ordian added a commit that referenced this pull request Jul 22, 2022
@ordian
Merge branch 'master' into ao-malus-delay-finality
c31de45 
* master:
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  `staking-miner`:  Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780)
  Zombienet: paritydb test (#5310)
  Fix Typo (#5766)
  Fix Core Version display in the release notes (#5781)
  companion for new pools reward scheme (#5757)
  fix disable-runtime-api feature flag (#5773)
  split NetworkBridge into two subsystems (#5616)
  Implement prune only stagnant check mode (#5761)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepoviola pepoviola pepoviola left review comments

@drahnr drahnr drahnr approved these changes

@chevdor chevdor chevdor approved these changes

@ordian ordian ordian approved these changes

@radupopa2010 radupopa2010 radupopa2010 approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zombienet: add a test with --db=paritydb-experimental
6 participants
@sandreim @chevdor @pepoviola @drahnr @ordian @radupopa2010