Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add Extrinsic Ordering check that runs against a local reference node #5790

Merged
merged 7 commits into from
Jul 19, 2022
Merged

add Extrinsic Ordering check that runs against a local reference node #5790

merged 7 commits into from
Jul 19, 2022

Conversation

coderobe
Copy link
Contributor

implements #5762

@coderobe coderobe added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 19, 2022
@coderobe coderobe requested review from a team and chevdor as code owners July 19, 2022 12:10
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 12:10
chevdor
chevdor suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Using a matrix would help making it both simpler and faster.

.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 12:41
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 12:48
@coderobe
Copy link
Contributor Author

tested & working
see https://github.com/coderobe/polkadot/actions/runs/2697804281

@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 13:04
chevdor
chevdor suggested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the logs to tell us the truth

.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 13:07
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 13:15
@coderobe coderobe requested a review from chevdor July 19, 2022 13:19
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 13:38
chevdor
chevdor approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion and LGTM

.github/workflows/release-21_extrinsic-ordering-check-from-two.yml Outdated Show resolved Hide resolved
@coderobe coderobe merged commit f6831e9 into master Jul 19, 2022
@coderobe coderobe deleted the coderobe/extrinsic-refnode branch July 19, 2022 15:12
@coderobe coderobe mentioned this pull request Jul 19, 2022
Closed
ordian added a commit that referenced this pull request Jul 22, 2022
@ordian
Merge branch 'master' into ao-malus-delay-finality
c31de45 
* master:
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  `staking-miner`:  Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780)
  Zombienet: paritydb test (#5310)
  Fix Typo (#5766)
  Fix Core Version display in the release notes (#5781)
  companion for new pools reward scheme (#5757)
  fix disable-runtime-api feature flag (#5773)
  split NetworkBridge into two subsystems (#5616)
  Implement prune only stagnant check mode (#5761)
@Dengjianping Dengjianping mentioned this pull request Jul 27, 2022
Closed
ordian added a commit that referenced this pull request Jul 28, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
95cd87d 
* master: (37 commits)
  Backport crate version bumps to 0.9.27 (#5826)
  Fix GHA (#5825)
  [ci] Add timeout to benchmark jobs (#5822)
  Parachains db column "migration" (#5797)
  Companion for #11831 (#5784)
  [ci] Return production image (#5818)
  add migration for staking v10 (#5817)
  Prepare for rust 1.62.1 (#5811)
  Bump strum to 0.24.1 (#5816)
  Bump substrate (#5814)
  Add missing trigger wildcards for some CI workflows (#5812)
  malus: add `finality_delay` cli flag (#5770)
  [ci] publish parachain-implementers-guide (#5806)
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderobe @chevdor @EgorPopelyaev