Merged
Conversation
added 5 commits
November 4, 2024 17:14
Generate changelog in
|
mpritham
commented
Nov 6, 2024
ac2bcd2 to
e148180
Compare
mpritham
commented
Nov 6, 2024
conjure-java-core/src/integrationInput/java/com/palantir/product/UndertowErrorService.java
Outdated
Show resolved
Hide resolved
mpritham
commented
Nov 6, 2024
mpritham
commented
Nov 6, 2024
...ava-core/src/integrationInput/java/com/palantir/product/ServerEndpointSpecificTwoErrors.java
Outdated
Show resolved
Hide resolved
bf0d2aa to
86cf0f3
Compare
86cf0f3 to
4db6495
Compare
1b468d2 to
83c7ea0
Compare
Contributor
Author
|
This is good for a re-review. Shouldn't be merged: it has the CheckedServiceException class which we'd like to be in the conjure-java-runtime-api repo, it uses an RC version of conjure. Going to branch off of this to work on the error serialization piece. |
carterkozak
reviewed
Nov 7, 2024
conjure-java-core/src/integrationInput/java/com/palantir/another/ServerConjureErrors.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 7, 2024
...a-core/src/main/java/com/palantir/conjure/java/services/UndertowServiceHandlerGenerator.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 7, 2024
conjure-java-core/src/main/java/com/palantir/conjure/java/util/ErrorGenerationUtils.java
Outdated
Show resolved
Hide resolved
f49fa60 to
673f89d
Compare
carterkozak
reviewed
Nov 7, 2024
conjure-java-core/src/main/java/com/palantir/conjure/java/util/ErrorGenerationUtils.java
Outdated
Show resolved
Hide resolved
673f89d to
811e1ef
Compare
mpritham
commented
Nov 8, 2024
...core/src/main/java/com/palantir/conjure/java/services/UndertowServiceInterfaceGenerator.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 8, 2024
...core/src/main/java/com/palantir/conjure/java/services/UndertowServiceInterfaceGenerator.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 8, 2024
conjure-java-core/src/main/java/com/palantir/conjure/java/util/Javadoc.java
Show resolved
Hide resolved
This was referenced Nov 18, 2024
added 2 commits
November 18, 2024 12:30
… into pm/endpoint-errors
carterkozak
reviewed
Nov 18, 2024
versions.props
Outdated
Comment on lines
9
to
12
| com.palantir.conjure.java.api:* = 2.56.0-rc1 | ||
| com.palantir.conjure.java.runtime:* = 8.7.0 | ||
| com.palantir.conjure.verification:* = 0.19.0 | ||
| com.palantir.conjure:* = 4.36.0 | ||
| com.palantir.conjure:* = 4.50.0-rc2 |
Contributor
There was a problem hiding this comment.
we should be able to update both of these now
Contributor
|
Looks good, just needs a changelog! |
carterkozak
approved these changes
Nov 18, 2024
|
Released 8.32.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Endpoint errors were added to the Conjure specification in this PR. conjure-java does not use user-defined endpoint errors.
After this PR
Generated
ServerErrorsclassesDevelopers will be able to create checked exceptions for each error that is defined as an error an endpoint can throw. Specifically, for each endpoint-defined error,
conjure-javawill generate a class for the error's namespace with name{namespace}ServerErrors. This class will hold the definition of an exception, which is a sub-class ofCheckedServiceException(introduced here), as well as methods to construct the exception.Changes to
ErrorsclassesWhen an error is used as an endpoint error, factory methods to create
ServiceExceptions are no longer provided in theErrorsutility classes. 🌶️ This means that once an error becomes associated with an endpoint, it can no longer be used to throw un-checked runtime exceptions. This is intentional and acts as a forcing function for adoption: associating errors with one endpoint will require users to add endpoint errors for all of the endpoints throwing the error.Updates to Undertow Service Interfaces and Handlers
For each endpoint that defines endpoint-errors, the corresponding endpoint in the Undertow service interface, and the endpoint handler method, will include a
throwsclause including the list of checked exceptions corresponding to the endpoint errors, that were generated in theServerErrorsclass (see above).Jersey
Endpoint errors will not be supported on Jersey servers. An exception will be thrown if a user attempts to generate code for Jersey services with endpoint errors defined.
==COMMIT_MSG==
Support endpoint errors
==COMMIT_MSG==
Possible downsides?