Deprecate CheckedServiceException constructors#1401
Merged
bulldozer-bot[bot] merged 3 commits intodevelopfrom Jul 31, 2025
Merged
Deprecate CheckedServiceException constructors#1401bulldozer-bot[bot] merged 3 commits intodevelopfrom
CheckedServiceException constructors#1401bulldozer-bot[bot] merged 3 commits intodevelopfrom
Conversation
Generate changelog in
|
CheckedServiceExceptionCheckedServiceException constructors
|
Released 2.62.0 |
mpritham
pushed a commit
that referenced
this pull request
Aug 12, 2025
Deprecate `CheckedServiceException` constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
CheckedServiceExceptionwas added in #1262 to be leveraged by palantir/conjure-java#2401, but was since updated to rely on unchecked exceptions with #1352 and palantir/conjure-java#2549CheckedServiceExceptionwas kept for backwards compatibility with code that was already generated with these, but the intent was to remove it. As is though, there already exist certain cases of it being leveraged outside of even conjure (by directly extending it).We should make it clear that this is unintended usage by deprecating at least the constructors, and track down usage to get rid of it everywhere that constructs
CheckedServiceExceptionsAfter this PR
==COMMIT_MSG==
Deprecate
CheckedServiceExceptionconstructors==COMMIT_MSG==
Note that I'm only deprecating the constructors to indicate we shouldn't subclass, but not the class itself to avoid deprecation notices in places that still need to support it for backwards compatibility (for now), such as conjure-undertow-runtime and the likes
Possible downsides?