Add checked service exception, used for endpoint associated errors#1262
Add checked service exception, used for endpoint associated errors#1262bulldozer-bot[bot] merged 5 commits intodevelopfrom
Conversation
Generate changelog in
|
errors/src/main/java/com/palantir/conjure/java/api/errors/ServiceError.java
Outdated
Show resolved
Hide resolved
3f90f79 to
10c2c07
Compare
10c2c07 to
095d16b
Compare
errors/src/main/java/com/palantir/conjure/java/api/errors/ServiceExceptionUtils.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void testErrorIdsAreInheritedFromCheckedServiceExceptions() { |
There was a problem hiding this comment.
Let's add another variant of this test where the rootCause is a regular ServiceException, and the inverse in the ServiceExceptionTest where the rootCause is a CheckedServiceException for completeness
| /** | ||
| * Creates a new exception for the given error. | ||
| */ |
There was a problem hiding this comment.
let's duplicate the javadoc from ServiceException:
There was a problem hiding this comment.
(updated not to describe serialization)
carterkozak
left a comment
There was a problem hiding this comment.
A couple javadoc and test nits, approving to cut a release candidate based on this in the interim to unblock the other PRs :-]
Invalidated by push of 3af92d0
3af92d0 to
e006e93
Compare
errors/src/main/java/com/palantir/conjure/java/api/errors/CheckedServiceException.java
Outdated
Show resolved
Hide resolved
errors/src/test/java/com/palantir/conjure/java/api/errors/TestCheckedServiceException.java
Outdated
Show resolved
Hide resolved
|
👍 this looks good to me |
|
Released 2.56.0 |
Before this PR
In order to support work to generated checked exceptions for endpoint associated errors, we need to add a
CheckedServiceException.Please see this PR in conjure for high level context, and this PR in
conjure-javafor context on the Java-specific implementation.After this PR
==COMMIT_MSG==
Add a checked service exception, used for endpoint associated errors
==COMMIT_MSG==
Possible downsides?