Ensure endpoint associated error serialization follows the Conjure spec#2402
Merged
mpritham merged 16 commits intopm/endpoint-errorsfrom Nov 18, 2024
Merged
Ensure endpoint associated error serialization follows the Conjure spec#2402mpritham merged 16 commits intopm/endpoint-errorsfrom
mpritham merged 16 commits intopm/endpoint-errorsfrom
Conversation
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
aa2b4b2 to
768274e
Compare
carterkozak
reviewed
Nov 8, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 8, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Show resolved
Hide resolved
carterkozak
reviewed
Nov 8, 2024
...rtow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptions.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 8, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Show resolved
Hide resolved
mpritham
force-pushed
the
pm/endpoint-errors
branch
3 times, most recently
from
02535ab to
a573b92
Compare
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
2 times, most recently
from
073ab94 to
37c970f
Compare
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
37c970f to
70cc1c1
Compare
…dpoint-error-serialization
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
e1d15a6 to
9125ce1
Compare
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
9125ce1 to
8ab8190
Compare
mpritham
commented
Nov 14, 2024
...me/src/test/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptionHandlerTest.java
Show resolved
Hide resolved
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
6 times, most recently
from
e63f11a to
1ba0c36
Compare
mpritham
commented
Nov 14, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Outdated
Show resolved
Hide resolved
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
1ba0c36 to
ab0b351
Compare
carterkozak
reviewed
Nov 14, 2024
...rtow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptions.java
Show resolved
Hide resolved
carterkozak
reviewed
Nov 14, 2024
...me/src/test/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 14, 2024 19:34
carterkozak
reviewed
Nov 15, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 15, 2024
...me/src/test/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 15, 2024
...me/src/test/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 15, 2024
...me/src/test/java/com/palantir/conjure/java/undertow/runtime/ConjureExceptionHandlerTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 15, 2024
mpritham
changed the title
mpritham
changed the title
mpritham
commented
Nov 18, 2024
| ConjureError error = CLIENT_JSON_MAPPER.readValue(getErrorBody(connection), ConjureError.class); | ||
| assertThat(error.errorName()).isEqualTo("Default:Conflict"); | ||
| assertThat(error.errorCode()).isEqualTo("CONFLICT"); | ||
| assertThat(error.parameters()).containsOnlyKeys("optionalInt", "arg", "optionalDouble", "optional"); |
Contributor
Author
There was a problem hiding this comment.
notably the keys nullValue, emptyOptionalInt, emptyOptionalDouble, and emptyOptional are not in the map as expected.
mpritham
commented
Nov 18, 2024
...-undertow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureError.java
Outdated
Show resolved
Hide resolved
policy-bot
bot
dismissed
carterkozak’s stale review
Invalidated by push of 667d310
…dpoint-error-serialization
mpritham
commented
Nov 18, 2024
mpritham
force-pushed
the
pm/endpoint-error-serialization
branch
from
1490b3f to
40fbfe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Builds on #2401. Serialize the arguments in
CheckedServiceExceptions asConjureErrorsAfter this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?