-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sprite][Color][Anim] Various Pokemon Sprite Fixes (WIP) #4346
Draft
pom-eranian
wants to merge
29
commits into
pagefaultgames:beta
Choose a base branch
from
pom-eranian:beta
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24,692
−52,146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed chopped up legs in Front Base, Front Shiny, Back Base and Back Shiny. - Fixed in all animations a single choppy/weird animation loop that cut off and gave the animation itself a weird janky feeling. Removed it entirely. - Fixed .json files accordingly. All files should be indexed, too.
- Moves Front Base and Front Shiny to the center of the stage via adding padding to the right side of the sprite (currently the total width is 96 pixels wide, biggest allowed) and by centering the frames. - Both should work and Vanillite doesn't have variants yet.
- Fixed Front Shiny exp for Tyrunt (used to have the base color in 5/6 of the frames of its exp on the tailspike, it should load properly now without flicker). - !! IMPORTANT !! Back Shiny exp for Tyrunt is currently unused because there's a worse copy of it in the /variant/exp/back folder (and I've checked and this is the one the masterlist calls for) it'd be best to revert it as the one in /variant/exp/back has extra colors due to two weird pixels + there's no real need as Tyrunt doesn't have a Base Replace - Epic variant has been tweaked for all sprites to un-custom the eye (as it had been edited to have a slit eye instead of the ring it should have in Tyrantrum and a slightly modified ring in Tyrunt) and slightly tweak the claws (in Tyrunt, the arm claws had an extra unneeded color as border that caused issues, in Tyrantrum they weren't split properly for a change the Epic introduced). (This affects: Static Front, Static Back, Front exp, Back exp) - Base sprites have been edited so all variants can load from shader/.json file. .json file has been put in its respective folder and should work. - All spritesheets should be indexed and clean.
[Sprite] 451 - Skorupi Animation Fix - @ rival_kieran
[Sprite] 696 697 Tyrunt Tyrantrum [Colorfixes] - @ rival_kieran
all front colors have identical json values all back colors have identical json values
[Sprite] 582 Vanillite [Position Fix] - @rival_kieran
[Sprite] 774-Minior spritesheet fixes
Adjusted base sprites to get rid of floating mouth corner. Sprites have been saved in indexed format.
Recolored the new base sprites in the Variant colors. Affected sprites: All Toxicroak front sprites added a gender difference - Rare male and epic female changed colors compared to the previous version. Affected sprites: Male rare sprites, female epic sprites.
[Sprite] 453 454 Croagunk Toxicroak (base fix & female vatiants) @ vari
[Sprite] 493 Arceus-fairy matching spritesheet and json
[Sprite] Galarian Bird Variants to JSON
fixed clipped horn on kirlia front and back standard palettes ignore mega gardevoir and gallade for now.
[Sprite] 280 281 282 Ralts Kirlia Gardevoir Palette standarized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation of sprite fixes from various artists. Fix details and images linked here:
Parasect
Clefable
62 Poliwrath -- [BUG] Poliwrath Sprite Animation[...] #1756
281 Kirlia [Sprite][Anim] Kirlia clipped back sprite #4177
451 Skorupi Skorupi's legs clip out of view[...]#926
453 454 Croagunk Toxicroak
696 697 Tyrunt Tyrantrum
582 Vanillite
774 Minior -- [Bug][Anim] Minior's animation wraps around to the left #4130
6570 H.Zorua
493 Arceus_Fairy
Variants to palette:
715 Noivern
735 736 737 Charcadet Ceruledge Armarouge
773 Sylvally
4144 4145 4146 G.Articuno, G.Zapdos, G.Moltres
Checklist
beta
as my base branch- [ ] The PR is self-contained and cannot be split into smaller PRs?- [ ] Have I considered writing automated tests for the issue?- [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)