Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite] 774-Minior spritesheet fixes #6

Merged
merged 6 commits into from
Sep 22, 2024
Merged

[Sprite] 774-Minior spritesheet fixes #6

merged 6 commits into from
Sep 22, 2024

Conversation

pom-eranian
Copy link
Owner

@pom-eranian pom-eranian commented Sep 22, 2024

all minior cores now have identical color indexing, spritesheet framing and json animation.

[Bug][Anim] Minior's animation wraps around to the left #4130

Screenshots/Videos

4203b5a8-3199-4491-982a-a8be8d824de3.mp4

How to test the changes?

set for player and opponent
species: minior
form: increment to see each color
shiny: set as needed
has no variants

to rid the shield quickly
level: 20
moveset: dragon rage x4

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [ ] Have I considered writing automated tests for the issue?
    - [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@pom-eranian pom-eranian merged commit dcd0711 into beta Sep 22, 2024
15 checks passed
@pom-eranian pom-eranian deleted the sprite-minior branch September 26, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant