Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite] Galarian Bird Variants to JSON #9

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

pom-eranian
Copy link
Owner

4144 Articuno
4145 Zapdos
4146 Moltres

What are the changes the user will see?

Backsprite for g. moltres variants will show up. (reported by different people)
The colors for any sprite of the same variant are exactly the same

Why am I making these changes?

  • Part of asset cleanup.
  • Fixes visual bug for galarian moltres
  • just because, i guess.

What are the changes from a developer perspective?

Created palette json files for front, back and exp front
Edited _masterlist.json to use a color swap instead of images on these pokemon.

Screenshots/Videos: the garbled ones are 'animated' :/

a3b67948-93b3-44cd-a47b-8348b6df308f
3a1051e5-a627-4299-a46d-1e8cfac2c7cd
49736722-bd74-4384-a339-b9cc691b8738
5bc9d831-32b5-479c-a694-9c6cd7771868
6ed9c63b-fc57-4a03-8202-e5235e283203
275ddecc-6ad7-4e59-bdc5-664ca70820c6
db46cf2a-3027-4295-ad13-5a8c26163329
82cfc1b3-2639-4710-ad60-473ad06c9067

eb27d308-14f2-4192-a165-e4725d39e0b8
8643c0b3-c2a0-4351-8566-e3d51cd97724
e83c46bb-abde-4359-8636-a6b94db95c0a
e8b60dfe-ce45-4459-9686-23e87a4ef0e0
f1e3dccf-a713-4cc6-9b81-d2cba85970c8
9440cbc3-e288-4ef6-ba06-7b81ee2b0b27
0ee9cfb2-9817-424b-b6db-2d95352902ac
13edd702-dc83-41ab-a841-4b5f086c50f3

aebf3294-ba14-45d7-b7ea-260d07329050
forgot one but if the variants work, the base works.
73df6889-1ef9-496c-8b67-6e1d97fc7bac
88998579-50a9-49a3-8040-cd63697b0178
8f3b1380-9aef-48d6-a36c-375a3781e2cd
f5392973-50dd-4858-9587-bfca12f3c843
e6de298b-6efa-4bdc-b106-babbe20a3820
906ba373-f5f3-4ad0-aa6d-14b377525681

How to test the changes?

set sprites to mixed animated
set species to each of the following: 4144, 4145, 4146
set values for shiny and variant as needed

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [ ] Have I considered writing automated tests for the issue?
    - [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@pom-eranian pom-eranian merged commit 4aa3b45 into beta Sep 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant