Skip to content

refactor(napi/parser, linter/plugins): improve formatting of generated code #14554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

refactor(napi/parser, linter/plugins): improve formatting of generated code #14554

merged 1 commit into from
Oct 13, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 13, 2025 •
edited
Loading

Tiny improvement to generated code. Break up the code with line breaks in more places, to make it a little easier to read.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 13, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Oct 13, 2025
Merged
camc314
camc314 reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider piping it through dprint?

@overlookmotel overlookmotel marked this pull request as ready for review October 13, 2025 12:20
@overlookmotel overlookmotel self-assigned this Oct 13, 2025
@camc314 camc314 added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Oct 13, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Oct 13, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Oct 13, 12:20 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 13, 12:21 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 13, 12:24 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Oct 13, 12:30 PM UTC: Merged by the Graphite merge queue.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
@overlookmotel
Copy link
Member Author

overlookmotel commented Oct 13, 2025 •
edited
Loading

consider piping it through dprint?

We already do. But it doesn't add line breaks where there was none before. Problem is that we're running code through minifier, and that removes all the line breaks, so we have to add them back in manually prior to dprint.

@overlookmotel
refactor(napi/parser, linter/plugins): improve formatting of generate…
4f301de 
…d code (#14554)

Tiny improvement to generated code. Break up the code with line breaks in more places, to make it a little easier to read.
@graphite-app graphite-app bot force-pushed the 10-13-refactor_napi_parser_linter_plugins_shorten_generated_raw_transfer_deserializer_code branch from d85ff14 to 68c0252 Compare October 13, 2025 12:24
@graphite-app graphite-app bot force-pushed the 10-13-refactor_napi_parser_linter_plugins_improve_formatting_of_generated_code branch from 270a2b1 to 4f301de Compare October 13, 2025 12:25
Base automatically changed from 10-13-refactor_napi_parser_linter_plugins_shorten_generated_raw_transfer_deserializer_code to main October 13, 2025 12:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
@camc314
Copy link
Contributor

camc314 commented Oct 13, 2025

consider piping it through dprint?

We already do. But it doesn't add line breaks where there was none before. Problem is that we're running code through minifier, and that removes all the line breaks, so we have to add them back in manually prior to dprint.

gotchu, thanks for explaining

@graphite-app graphite-app bot merged commit 4f301de into main Oct 13, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 10-13-refactor_napi_parser_linter_plugins_improve_formatting_of_generated_code branch October 13, 2025 12:30
@Boshen Boshen mentioned this pull request Oct 13, 2025
Merged
camc314 added a commit that referenced this pull request Oct 13, 2025
@Boshen @camc314
release(oxlint): v1.23.0 (#14560)
0082cda 
## [1.23.0] - 2025-10-13

### 🚀 Features

- 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus)
- a9e1261 linter: Implement react-refresh/only-export-components
(#14122) (Rintaro Itokawa)
- a8d542b linter/no-duplicate-imports: Support
`allowSeparateTypeImports` option (#14527) (camc314)
- 75a529c linter: Add run info about what functions rules implement
(#13839) (camchenry)
- 4fbdef2 language_server: Support `fmt.configPath` configuration
(#14502) (Sysix)
- 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466)
(Sysix)

### 🐛 Bug Fixes

- fb4a20d language_server: Add whitespace for `//
oxlint-disable-next-line` fix (#14356) (Sysix)
- 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528)
(camc314)
- 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names
(#14541) (magic-akari)
- 9965676 linter/exhaustive-deps: Ignore empty strings passed to
`additionalHooks` option (#14464) (Redas)
- d0a8e3e linter: `vue/no_required_prop_with_default` called
`Option::unwrap()` on a `None` value (#14491) (Sysix)
- 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480)
(shulaoda)
- 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314)

### 🚜 Refactor

- 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix)
- f599bef language_server: Move `Message` to `DiagnosticReport`
transformation to one place (#14447) (Sysix)
- 4f301de napi/parser, linter/plugins: Improve formatting of generated
code (#14554) (overlookmotel)
- 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer
deserializer code (#14553) (overlookmotel)
- 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix)
- 9e9c5ba linter: Simplify built-in lint plugin checks (#14518)
(camchenry)
- 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314)
- ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314)
- a9cea7c language_server: Use `FxHashSet` for
`ServerLinter::extended_paths` (#14517) (Sysix)
- ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314)
- f977700 language_server: Pass `LintOptions` to
`Worker::refresh_server_linter` (#14510) (Sysix)
- 54b001f linter/no-new-require: Improve diagnostic message clarity
(#14511) (shulaoda)
- 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda)

### 📚 Documentation

- 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514)
(camc314)
- d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470)
(shulaoda)

### ⚡ Performance

- b44a30e language_server: Transform `Message` to `DiagnosticReport`
with one call (#14448) (Sysix)
- 31766fd linter/plugins: Provide `loc` via prototype (#14552)
(overlookmotel)
- aec0c08 linter: Allow analyzing node types in match blocks with guards
(#14459) (camchenry)
- 9044187 linter: Skip running node-specific rule if file contains no
relevant nodes (#14457) (camchenry)
- 422f54e linter: Only run rule run functions if implemented (#14454)
(camchenry)
- 2c228ae liner: Use top-level match for `no_obj_calls` (#14523)
(camchenry)
- c49d891 linter: Use match for `no_negated_condition` (#14522)
(camchenry)
- e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry)
- 4440516 linter: Refactor rules to take advantage of node type skipping
(#14519) (camchenry)
- 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily
analyzed (#14458) (camchenry)

### 🧪 Testing

- 8d8881d linter/plugins: Expand tests for module resolution of plugins
(#14559) (overlookmotel)
- 33b6cde language_server: Add basic tests for
`WorkspaceWorker::did_change_configuration` (#14531) (Sysix)
- bfe1ecd language_server: Add tests for
`WorkspaceWorker::init_watchers` (#14516) (Sysix)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
@Boshen Boshen mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@overlookmotel overlookmotel

Labels

A-ast-tools Area - AST tools A-cli Area - CLI A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314