perf(linter): skip running node-specific rule if file contains no relevant nodes #14457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #14457 will improve performances by 19.08%Comparing Summary
Benchmarks breakdown
Footnotes
|
camchenry
force-pushed
the
10-08-perf_linter_skip_running_node-specific_rule_if_file_contains_no_relevant_nodes
branch
from
2fa95b7 to
fd64561
Compare
camchenry
force-pushed
the
10-08-perf_linter_only_run_rule_run_functions_if_implemented
branch
from
b253964 to
2dd6c2c
Compare
camc314
approved these changes
Oct 12, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
10-08-perf_linter_only_run_rule_run_functions_if_implemented
branch
from
2dd6c2c to
d21833b
Compare
graphite-app
bot
force-pushed
the
10-08-perf_linter_skip_running_node-specific_rule_if_file_contains_no_relevant_nodes
branch
from
fd64561 to
17956c1
Compare
camc314
force-pushed
the
10-08-perf_linter_only_run_rule_run_functions_if_implemented
branch
from
d21833b to
4820038
Compare
camc314
changed the base branch from
10-08-perf_linter_only_run_rule_run_functions_if_implemented
to
graphite-base/14457
camc314
force-pushed
the
graphite-base/14457
branch
from
4820038 to
422f54e
Compare
camc314
force-pushed
the
10-08-perf_linter_skip_running_node-specific_rule_if_file_contains_no_relevant_nodes
branch
from
17956c1 to
6076df3
Compare
camc314
changed the base branch from
graphite-base/14457
to
10-08-perf_linter_only_run_rule_run_functions_if_implemented
camc314
changed the base branch from
10-08-perf_linter_only_run_rule_run_functions_if_implemented
to
graphite-base/14457
camc314
force-pushed
the
10-08-perf_linter_skip_running_node-specific_rule_if_file_contains_no_relevant_nodes
branch
from
6076df3 to
9044187
Compare
graphite-app
bot
deleted the
10-08-perf_linter_skip_running_node-specific_rule_if_file_contains_no_relevant_nodes
branch
camc314
added a commit
that referenced
this pull request
Oct 13, 2025
## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally making use of the optimizations enabled by #13137. We can use the AST type bitset for each file to skip rules that only care about specific node types if the file has none of those node types.