feat: Convert event_tag_utils module to TS #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
2 times, most recently
from
6f5d89e to
a1cbc3d
Compare
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
from
a1cbc3d to
172b7ae
Compare
…izely/javascript-sdk into mcarroll/optimizely-sdk-typescript
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
2 times, most recently
from
2512009 to
c5ed708
Compare
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
from
c5ed708 to
f99e533
Compare
…izely/javascript-sdk into mcarroll/optimizely-sdk-typescript
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
from
f99e533 to
7caeddd
Compare
mjc1283
suggested changes
Jul 30, 2020
| @@ -15,6 +15,9 @@ | |||
| */ | |||
| import { sprintf } from '@optimizely/js-sdk-utils'; | |||
|
|
|||
| import { EventTags } from '../../../../event-processor/src/events'; | |||
| import { LoggerFacade } from '../../../../logging/src/models'; | |||
There was a problem hiding this comment.
Suggested change
| import { LoggerFacade } from '../../../../logging/src/models'; | |
| import { LoggerFacade } from '@optimizely/js-sdk-logging'; |
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
from
034f8db to
f69fd61
Compare
yavorona
commented
Jul 30, 2020
| let revenue = null; | ||
| let eventValue = null; | ||
|
|
||
| if (eventTags) { |
There was a problem hiding this comment.
@mjc1283 FYI if (eventTags) {...} already exists in event_builder/index.js, so this is the only place where we need to put it.
mjc1283
suggested changes
Jul 30, 2020
| */ | ||
| import { sprintf } from '@optimizely/js-sdk-utils'; | ||
|
|
||
| import { EventTags } from '../../../../event-processor/src/events'; |
There was a problem hiding this comment.
Oops, I missed this one last time.
Just like the logging import - we can't reach into other packages. They are published separately.
Suggested change
| import { EventTags } from '../../../../event-processor/src/events'; | |
| import { EventTags } from '@optimizely/js-sdk-event-processor'; |
Comment on lines
34
to
35
| let parsedRevenueValue; | ||
| let parsedEventValue; |
There was a problem hiding this comment.
Normally I would suggest declaring these inside the functions where they're used. Let me know your thoughts on declaring them here vs. inside.
There was a problem hiding this comment.
You are absolutely right, we should keep them inside the code block where they are being used. :)
yavorona
force-pushed
the
pnguen/convert-event-tags-utils-to-ts
branch
from
75ab813 to
a61a375
Compare
mjc1283
approved these changes
Jul 30, 2020
yavorona
added a commit
that referenced
this pull request
Aug 1, 2020
* Convert event_tag_utils module to TS * Convert event_tag_utils module to TS * Add type guard to avoid using any * Move 'if (eventTags)' to top level functions * Move let variables to inside the functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
event_tag_utilsmodule from JS to TS.Test plan