Skip to content

Commit 6f5d89e

Browse files
committed
Convert event_tag_utils module to TS
1 parent fd1c2dc commit 6f5d89e

File tree

4 files changed

+18
-20
lines changed

4 files changed

+18
-20
lines changed

packages/optimizely-sdk/lib/core/event_builder/event_helpers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { getLogger } from '@optimizely/js-sdk-logging';
1717

1818
import fns from '../../utils/fns';
1919
import projectConfig from '../project_config';
20-
import eventTagUtils from '../../utils/event_tag_utils';
20+
import * as eventTagUtils from '../../utils/event_tag_utils';
2121
import attributesValidator from'../../utils/attributes_validator';
2222

2323
var logger = getLogger('EVENT_BUILDER');

packages/optimizely-sdk/lib/core/event_builder/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import fns from '../../utils/fns';
1717
import enums from '../../utils/enums';
1818
import projectConfig from '../project_config';
19-
import eventTagUtils from '../../utils/event_tag_utils';
19+
import * as eventTagUtils from '../../utils/event_tag_utils';
2020
import attributeValidator from '../../utils/attributes_validator';
2121

2222
var ACTIVATE_EVENT_KEY = 'campaign_activated';

packages/optimizely-sdk/lib/utils/event_tag_utils/index.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import sinon from 'sinon';
1717
import { assert } from 'chai';
1818

19-
import eventTagUtils from './';
19+
import * as eventTagUtils from './';
2020

2121
describe('lib/utils/event_tag_utils', function() {
2222
var mockLogger;

packages/optimizely-sdk/lib/utils/event_tag_utils/index.js renamed to packages/optimizely-sdk/lib/utils/event_tag_utils/index.ts

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
*/
1616
import { sprintf } from '@optimizely/js-sdk-utils';
1717

18+
import { EventTags } from '../../../../event-processor/src/events';
19+
import { LoggerFacade } from '../../../../logging/src/models';
20+
1821
import {
1922
LOG_LEVEL,
2023
LOG_MESSAGES,
@@ -30,45 +33,40 @@ var VALUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.VALUE;
3033

3134
/**
3235
* Grab the revenue value from the event tags. "revenue" is a reserved keyword.
33-
* @param {Object} eventTags
34-
* @param {Object} logger
35-
* @return {Integer|null}
36+
* @param {EventTags} eventTags
37+
* @param {LoggerFacade} logger
38+
* @return {number|null}
3639
*/
37-
export var getRevenueValue = function(eventTags, logger) {
40+
export function getRevenueValue(eventTags: EventTags, logger: LoggerFacade): number | null {
3841
if (eventTags && eventTags.hasOwnProperty(REVENUE_EVENT_METRIC_NAME)) {
3942
var rawValue = eventTags[REVENUE_EVENT_METRIC_NAME];
40-
var parsedRevenueValue = parseInt(rawValue, 10);
43+
var parsedRevenueValue = parseInt(rawValue as any);
4144
if (isNaN(parsedRevenueValue)) {
4245
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_REVENUE, MODULE_NAME, rawValue));
4346
return null;
4447
}
4548
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_REVENUE_VALUE, MODULE_NAME, parsedRevenueValue));
4649
return parsedRevenueValue;
47-
}
50+
}
4851
return null;
4952
};
5053

5154
/**
5255
* Grab the event value from the event tags. "value" is a reserved keyword.
53-
* @param {Object} eventTags
54-
* @param {Object} logger
55-
* @return {Number|null}
56+
* @param {EventTags} eventTags
57+
* @param {LoggerFacade} logger
58+
* @return {number|null}
5659
*/
57-
export var getEventValue = function(eventTags, logger) {
60+
export function getEventValue(eventTags: EventTags, logger: LoggerFacade): number | null {
5861
if (eventTags && eventTags.hasOwnProperty(VALUE_EVENT_METRIC_NAME)) {
5962
var rawValue = eventTags[VALUE_EVENT_METRIC_NAME];
60-
var parsedEventValue = parseFloat(rawValue);
63+
var parsedEventValue = parseFloat(rawValue as any);
6164
if (isNaN(parsedEventValue)) {
6265
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_VALUE, MODULE_NAME, rawValue));
6366
return null;
6467
}
6568
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_NUMERIC_VALUE, MODULE_NAME, parsedEventValue));
6669
return parsedEventValue;
67-
}
70+
}
6871
return null;
6972
};
70-
71-
export default {
72-
getRevenueValue: getRevenueValue,
73-
getEventValue: getEventValue,
74-
};

0 commit comments

Comments
 (0)