Skip to content

Commit f99e533

Browse files
committed
Convert event_tag_utils module to TS
1 parent 995b82d commit f99e533

File tree

1 file changed

+26
-25
lines changed
  • packages/optimizely-sdk/lib/utils/event_tag_utils

1 file changed

+26
-25
lines changed

packages/optimizely-sdk/lib/utils/event_tag_utils/index.ts

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -27,47 +27,48 @@ import {
2727
/**
2828
* Provides utility method for parsing event tag values
2929
*/
30-
var MODULE_NAME = 'EVENT_TAG_UTILS';
31-
var REVENUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.REVENUE;
32-
var VALUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.VALUE;
30+
const MODULE_NAME = 'EVENT_TAG_UTILS';
31+
const REVENUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.REVENUE;
32+
const VALUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.VALUE;
3333

3434
/**
3535
* Grab the revenue value from the event tags. "revenue" is a reserved keyword.
3636
* @param {EventTags} eventTags
3737
* @param {LoggerFacade} logger
3838
* @return {number|null}
3939
*/
40-
4140
export function getRevenueValue(eventTags: EventTags, logger: LoggerFacade): number | null {
4241
if (eventTags && eventTags.hasOwnProperty(REVENUE_EVENT_METRIC_NAME)) {
43-
var rawValue = eventTags[REVENUE_EVENT_METRIC_NAME];
44-
var parsedRevenueValue = parseInt(rawValue as any);
45-
if (isNaN(parsedRevenueValue)) {
46-
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_REVENUE, MODULE_NAME, rawValue));
47-
return null;
48-
}
49-
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_REVENUE_VALUE, MODULE_NAME, parsedRevenueValue));
50-
return parsedRevenueValue;
42+
const rawValue = eventTags[REVENUE_EVENT_METRIC_NAME];
43+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
44+
const parsedRevenueValue = parseInt(rawValue as any);
45+
if (isNaN(parsedRevenueValue)) {
46+
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_REVENUE, MODULE_NAME, rawValue));
47+
return null;
5148
}
49+
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_REVENUE_VALUE, MODULE_NAME, parsedRevenueValue));
50+
return parsedRevenueValue;
51+
}
5252
return null;
53-
};
53+
}
5454

5555
/**
5656
* Grab the event value from the event tags. "value" is a reserved keyword.
57-
* @param {object} eventTags
58-
* @param {object} logger
59-
* @return {mumber|null}
57+
* @param {EventTags} eventTags
58+
* @param {LoggerFacade} logger
59+
* @return {number|null}
6060
*/
6161
export function getEventValue(eventTags: EventTags, logger: LoggerFacade): number | null {
6262
if (eventTags && eventTags.hasOwnProperty(VALUE_EVENT_METRIC_NAME)) {
63-
var rawValue = eventTags[VALUE_EVENT_METRIC_NAME];
64-
var parsedEventValue = parseFloat(rawValue as any);
65-
if (isNaN(parsedEventValue)) {
66-
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_VALUE, MODULE_NAME, rawValue));
67-
return null;
68-
}
69-
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_NUMERIC_VALUE, MODULE_NAME, parsedEventValue));
70-
return parsedEventValue;
63+
const rawValue = eventTags[VALUE_EVENT_METRIC_NAME];
64+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
65+
const parsedEventValue = parseFloat(rawValue as any);
66+
if (isNaN(parsedEventValue)) {
67+
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FAILED_TO_PARSE_VALUE, MODULE_NAME, rawValue));
68+
return null;
69+
}
70+
logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.PARSED_NUMERIC_VALUE, MODULE_NAME, parsedEventValue));
71+
return parsedEventValue;
7172
}
7273
return null;
73-
};
74+
}

0 commit comments

Comments
 (0)