Skip to content

Commit a61a375

Browse files
committed
Move let variables to inside the functions
1 parent f69fd61 commit a61a375

File tree

1 file changed

+3
-4
lines changed
  • packages/optimizely-sdk/lib/utils/event_tag_utils

1 file changed

+3
-4
lines changed

packages/optimizely-sdk/lib/utils/event_tag_utils/index.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
import { sprintf } from '@optimizely/js-sdk-utils';
1717

18-
import { EventTags } from '../../../../event-processor/src/events';
18+
import { EventTags } from '@optimizely/js-sdk-event-processor';
1919
import { LoggerFacade } from '@optimizely/js-sdk-logging';
2020

2121
import {
@@ -31,9 +31,6 @@ const MODULE_NAME = 'EVENT_TAG_UTILS';
3131
const REVENUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.REVENUE;
3232
const VALUE_EVENT_METRIC_NAME = RESERVED_EVENT_KEYWORDS.VALUE;
3333

34-
let parsedRevenueValue;
35-
let parsedEventValue;
36-
3734
/**
3835
* Grab the revenue value from the event tags. "revenue" is a reserved keyword.
3936
* @param {EventTags} eventTags
@@ -43,6 +40,7 @@ let parsedEventValue;
4340
export function getRevenueValue(eventTags: EventTags, logger: LoggerFacade): number | null {
4441
if (eventTags.hasOwnProperty(REVENUE_EVENT_METRIC_NAME)) {
4542
const rawValue = eventTags[REVENUE_EVENT_METRIC_NAME];
43+
let parsedRevenueValue;
4644
if (typeof rawValue === 'string') {
4745
parsedRevenueValue = parseInt(rawValue);
4846
if (isNaN(parsedRevenueValue)) {
@@ -71,6 +69,7 @@ export function getRevenueValue(eventTags: EventTags, logger: LoggerFacade): num
7169
export function getEventValue(eventTags: EventTags, logger: LoggerFacade): number | null {
7270
if (eventTags.hasOwnProperty(VALUE_EVENT_METRIC_NAME)) {
7371
const rawValue = eventTags[VALUE_EVENT_METRIC_NAME];
72+
let parsedEventValue;
7473
if (typeof rawValue === 'string') {
7574
parsedEventValue = parseFloat(rawValue);
7675
if (isNaN(parsedEventValue)) {

0 commit comments

Comments
 (0)