Skip to content

Difference Between FIrst Public Review and Current #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 168 commits into
base: main
Choose a base branch
from
Draft

Difference Between FIrst Public Review and Current #328

wants to merge 168 commits into from

Conversation

JasonGlazer
Copy link
Collaborator

Do not merge this.

JasonGlazer and others added 30 commits November 3, 2023 12:12
@JasonGlazer
Remove from line 3813 unprintable character that was causing problems…
f26fcc0 
… with Python YAML reader on linux
@JacksonJ-KC
Set values for 'AppG B_RMDs Same'
4aafb14
@JacksonJ-KC
reinsert newline
172a4ed
@JasonGlazer
Merge branch 'develop' into fix_unprintable_character
078f97b
@JasonGlazer
Merge pull request #239 from open229/fix_unprintable_character
5f477f7 
Fix unprintable character
@JasonGlazer
Add informative note on the branches to the README.md
ab29903
@JasonGlazer
Merge pull request #240 from open229/add_branch_note
e95604a 
Add informative note on the branches to the README.md
@JasonGlazer
Improve connection diagrams created from jsonSchemaToDot and rename.
dc1f29e
@JasonGlazer
Merge pull request #241 from open229/ImproveConnectionDiagrams
0026858 
Improve connection diagrams created from jsonSchemaToDot and rename.
@JasonGlazer
Add blank RESOURCES.md page and link from README.md
b0c3d86
@JasonGlazer
Add content to the RESOURCES.md file, mostly links.
033a789
@JasonGlazer
Merge pull request #244 from open229/Add_rmd_gen_resources
0e6fd34 
Add RMD generation resources
@JasonGlazer
Fix broken link, typo and text related to the resources page on the R…
2063bfd 
…EADME.md
@JasonGlazer
Merge pull request #245 from open229/fixReourcesBrokenLink
0f31886 
Fix broken link, typo and text related to the resources page on the readme
@JasonGlazer
Add chicago demo RMD files
0967157
@JasonGlazer
Change RMD to RPD
c3d7882
@JasonGlazer
Update README.md to be more accurate and use the right terms for the …
56ecf3e 
…various schemas
@JasonGlazer
Add system type examples
7fdf8f6
@JasonGlazer
Merge pull request #251 from open229/more_resources
c54dc6a 
Add more resources and update to RPD in the readme
@JasonGlazer
Fix name and link
945d4a3
@JasonGlazer
Fix typo
e1b2ea3
@JasonGlazer
Merge pull request #253 from open229/fix_createRPD_link
eef7ded 
Fix resources page for createRPD
@JasonGlazer
Increment version number to 0.0.37
a0a3feb
@JasonGlazer
Add notes to heating system heat pump and auxiliary temperature opera…
134cda0 
…tion for issue #211
@JasonGlazer
Add notes to Chiller for COPs to address #226
9df6576
@JasonGlazer
Fix typo in EnergyRecoveryOptions for #228
677b8e4
@JasonGlazer
Fix to use maximum in Terminal to address #233
af31ebb
@JasonGlazer
Add new options to PumpSpeedControlOptions to address #235
8bd46a5
@JasonGlazer
Expands on note for fluid_loops to address #242
440d092
@JasonGlazer
Clarify description and add note for service_water_piping for #243
cf564e4
JasonGlazer and others added 30 commits January 15, 2025 15:39
@JasonGlazer
Merge pull request #322 from open229/update-0.1.3
6509fdc 
Update 0.1.3
@JacksonJ-KC
correct handling array data types with elements that meet oneOf criteria
4453895
@JacksonJ-KC
remove _extra
35fbf28
@JacksonJ-KC
correct handling of min/max within arrays and reformat
389fe10
@JasonGlazer
Merge pull request #325 from open229/jjarboe-correct-array-with-oneOf
e300b9f 
Handle array data types with elements that meet `oneOf` criteria
@JasonGlazer
Update schema version number to 0.1.4
42e48ff
@JasonGlazer
Remove HEAT_PUMP from ChillerCompressorOptions since covered by Chill…
ae4ff02 
…erFunctionOptions to address #323
@JasonGlazer
Rename SWH options enumeration to be consist with how it is used. Add…
ee3b127 
…ressed #324
@JasonGlazer
Added notes to Schedule hourly*design elements to address #326
f9ad11f
@JasonGlazer
Add note to Construction.insulation_locations and r_values to clarify…
e0fd1ee 
… that the correspond to address #331
@JasonGlazer
Fix and clarify IPLV and NPLV enumerations to address #332 and #337
db07c99
@JasonGlazer
Remove unique fan elements and reference fan data group instead in Zo…
7442146 
…ne, Elevator, HeatRejection, and ServiceWaterHeatingEquipment to address #330 and #336
@JasonGlazer
Clarify weather design days and add evaporation design day to address #…
35fe9e2 
…327
@JasonGlazer
Add docs229 files
77a75d9
@JasonGlazer
Merge pull request #343 from open229/update-0.1.4
6c5d212 
Update 0.1.4
@JasonGlazer
Missing PDF Enumerations2019ASHRAE901.schema.pdf
e3f559b
@JasonGlazer
Merge pull request #345 from open229/update-0.1.4-oneMorePDF
617cf1d 
Missing PDF Enumerations2019ASHRAE901.schema.pdf
@JasonGlazer
Update schema version number to 0.1.5
6ca7907
@JasonGlazer
Add note for POSITIVE_DISPLACEMENT enumerator to address #339 and #355
a77f8f3
@JasonGlazer
Add STEAM energy source for EnergySourceOptions for absorption chille…
6023635 
…rs to address #342
@JasonGlazer
Replace use of -999 with Null to address #346
e837dc3
@JasonGlazer
Add AppG tags to Metadata data group to address #347
22c669a
@JasonGlazer
Add Version data type and MetaData.id ID data type to resolve #350
b0b3611
@JasonGlazer
Added NO_FAN options to heating and cooling metrics addressing #353
6995f54
@JasonGlazer
Change ChillerFunctionOption to CHILLED_OR_HOT_WATER to address #340
28daf4d
@JasonGlazer
Update all elements with Data Type Reference to use ID of the DataGro…
6824421 
…up to address #355
@JasonGlazer
Change service_water_heating_uses in both datagroups to address #349
5155e2f
@JasonGlazer
Move fan multiplier schedule back out of Fan to address #354
fbc33da
@JasonGlazer
Update docs229
37425c5
@JasonGlazer
Merge pull request #356 from open229/update-0.1.5
d52fc42 
Update 0.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGlazer @JacksonJ-KC