Handle array data types with elements that meet oneOf criteria
#325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I seem to have changed behavior of when elements in an array have a minimum/maximum value. I will try to fix this soon |
|
You made a bunch of changes to just reformat code. Could you walk me through the lines that fix the original bug? |
|
The formatting changes to follow PEP 8 make the code cleaner and easier to read for Python coders. This commit is the majority of the functional changes. Comments are added especially around the regex to make it easier to understand. Unless you see issues, I cannot spend more time on this than I already have. |
|
Thanks for pointing to that commit. I will try to learn from it! |
|
This seems to be working and fixes #321. Thanks very much @JacksonJ-KC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.