[chore] update jsonschema #8113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the jsonschema to the latest in main. It additionally adds a sed patch for making Headers a map[string]string instead of a map[string]interface. Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #8113 +/- ##
==========================================
- Coverage 90.55% 90.19% -0.36%
==========================================
Files 301 301
Lines 15317 15377 +60
==========================================
Hits 13870 13870
- Misses 1161 1221 +60
Partials 286 286
☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Jul 20, 2023
| # go-jsonschema always generates patternProperties as | ||
| # map[string]interface{}, for more specific types, they must | ||
| # be replaced here | ||
| s+type Headers.*+type Headers map[string]string+g |
There was a problem hiding this comment.
nit: I think an actual patch to be applied by patch would be more resilient here (not a fan of sed specially after open-telemetry/opentelemetry-collector-contrib/issues/23981)
There was a problem hiding this comment.
Fair, I can open an issue following this to use patch instead of sed for both jsonschema & proto generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the jsonschema to the latest in main. It additionally adds a sed patch for making Headers a map[string]string instead of a map[string]interface.
@mx-psi