Prepare release script sed usage is still fragile #23981
Closed
Description
Component(s)
No response
Describe the issue you're reporting
For releases we use the "Automation - Prepare Release" workflow, which uses this script to create a PR that is the first step of the contrib release.
It used to look like
and after #23977 it looks like
This sed
command may replace versions from dependencies we are replacing, which was the motivation for #23977. The current version still has some issues:
- The
.
on a version like0.80.0
are still interpreted as 'any character' bysed
, which is not what we want. A way to solve this is to do${CURRENT_BETA//\./\\.}
to escape dots as pointed out by @astencel-sumo - Even when solving (1), we still can run into issues if a dependency in the manifest were to exactly match the version used by the Collector (not something that can happen today with the current set of replaces).
We should rework how we handle this replacement to avoid issues in the future.