Add support for OTLP export for internal metrics #8097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8097 +/- ##
==========================================
+ Coverage 90.18% 90.24% +0.05%
==========================================
Files 301 301
Lines 15377 15449 +72
==========================================
+ Hits 13868 13942 +74
+ Misses 1222 1221 -1
+ Partials 287 286 -1
☔ View full report in Codecov by Sentry. |
jaronoff97
approved these changes
Jul 17, 2023
| opts := []otlpmetricgrpc.Option{} | ||
|
|
||
| if len(otlpConfig.Endpoint) > 0 { | ||
| opts = append(opts, otlpmetricgrpc.WithEndpoint(otlpConfig.Endpoint)) |
There was a problem hiding this comment.
should this be a required option?
There was a problem hiding this comment.
By default, if an environment variable is not set, and this option is not passed, "localhost:4317" will be used.
It is not required: https://pkg.go.dev/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc#WithEndpoint
codeboten
force-pushed
the
codeboten/jul7-otlp
branch
from
252cbfa
to
127e1a2
Compare
mx-psi
reviewed
Jul 18, 2023
mx-psi
reviewed
Jul 19, 2023
codeboten
force-pushed
the
codeboten/jul7-otlp
branch
from
54687d1
to
a41c0d2
Compare
added 3 commits
July 20, 2023 08:49
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/jul7-otlp
branch
from
a41c0d2
to
b1d0f13
Compare
mx-psi
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal collector metrics can now be exported via OTLP
using the otel-go otlpgrpc and otlphttp exporters.
Closes #7641
Follow up to #8113