update readme: warning clusteradm version #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, ycyaoxdu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 319a7ed
into
open-cluster-management-io:standalone-controlplane
xuezhaojun
pushed a commit
to xuezhaojun/OCM
that referenced
this pull request
Mar 21, 2023
Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 11, 2023
* add changelog for v0.7 (#122) Signed-off-by: Yang Le <yangle@redhat.com> * add changelog for v0.7.0 (#224) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add v0.7 changelog (#220) Signed-off-by: Wei Liu <liuweixa@redhat.com> * bump csv to 0.8.0 (#226) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * Merge label and annotation for unstructured (#126) Signed-off-by: Jian Qiu <jqiu@redhat.com> * upgrade go libraries (#127) Signed-off-by: Yang Le <yangle@redhat.com> * support Klusterlet.Spec.Namespace in hosted mode (#227) Signed-off-by: Yang Le <yangle@redhat.com> * Add lease permission for leader election (#229) Signed-off-by: Jian Qiu <jqiu@redhat.com> * upgrade lib (#228) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add permission for leases.coordination.k8s.io (#231) Signed-off-by: haoqing0110 <qhao@redhat.com> * set replica to 1 if kube version < v1.14 (#232) Signed-off-by: Yang Le <yangle@redhat.com> * upgrade go modules (#69) Signed-off-by: haoqing0110 <qhao@redhat.com> * Keep the finalizers unchanged for unstructured (#128) * Merge finalizer for unstructured Signed-off-by: zhujian <jiazhu@redhat.com> * Keep the finalizers unchanged Signed-off-by: zhujian <jiazhu@redhat.com> * Add test for keeping the finalizers unchanged Signed-off-by: zhujian <jiazhu@redhat.com> * set clusterset to default when value is null string (#222) Signed-off-by: ldpliu <daliu@redhat.com> * allow ManagedCluster creation with taint.timeAdded specified (#224) Signed-off-by: Yang Le <yangle@redhat.com> * Reduce queue size and add filter for csr informer (#223) 1. always return single key to queue so it will not blow up the queue 2. add filter for csr informer Signed-off-by: Jian Qiu <jqiu@redhat.com> * reduce the get request for managed cluster when checking managed cluster lease status (#226) Signed-off-by: Wei Liu <liuweixa@redhat.com> * Support multi arch image (#227) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix make images targe in post submit (#228) Signed-off-by: Jian Qiu <jqiu@redhat.com> * fix workdir issue for image action (#230) Signed-off-by: Jian Qiu <jqiu@redhat.com> * publish release artifact after image are built (#231) Signed-off-by: yue9944882 <291271447@qq.com> * enable multi-arch build (#130) Signed-off-by: Jian Qiu <jqiu@redhat.com> * update libs (#229) Signed-off-by: Wei Liu <liuweixa@redhat.com> * add lease permissions for library-go update (#233) Signed-off-by: Wei Liu <liuweixa@redhat.com> * fix webhook error (#232) Signed-off-by: ldpliu <daliu@redhat.com> * add missing permission on kube v1.11.0 (#234) Signed-off-by: Yang Le <yangle@redhat.com> * share release job env (#131) Signed-off-by: yue9944882 <291271447@qq.com> * share release job env (#233) Signed-off-by: yue9944882 <291271447@qq.com> * fix clusterset sync issue (#234) Signed-off-by: Yang Le <yangle@redhat.com> * fix kind create cluster --name (#237) Signed-off-by: panguicai008 <1121906548@qq.com> * add join permission on default clusterset (#236) Signed-off-by: Yang Le <yangle@redhat.com> * add join permission on defatult clusterset (#238) Signed-off-by: Yang Le <yangle@redhat.com> * Update golang builder in Dockerfile (#240) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update golang builder in Dockerfile (#237) Signed-off-by: Yang Le <yangle@redhat.com> * Update golang builder in Dockerfile (#70) Signed-off-by: Yang Le <yangle@redhat.com> * Update golang builder in Dockerfile (#133) Signed-off-by: Jian Qiu <jqiu@redhat.com> * chore: prune unused dockerfile cmd (#238) Signed-off-by: yue9944882 <291271447@qq.com> * passing IMAGE_TAG to make images (#239) Signed-off-by: yue9944882 <291271447@qq.com> * Multi-arch support (#240) * multi-arch support Signed-off-by: yue9944882 <291271447@qq.com> * refactor github workflow to support multi-arch build Signed-off-by: yue9944882 <291271447@qq.com> * add all clusterset permission (#241) Signed-off-by: ldpliu <daliu@redhat.com> * add all clusterset join permission (#241) Signed-off-by: ldpliu <daliu@redhat.com> * Remove unreachable redundant err check. (#134) Signed-off-by: Mike Ng <ming@redhat.com> * use new clusterset api (#242) Signed-off-by: ldpliu <daliu@redhat.com> * Add lint check in make verify (#135) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add lint check in make verify (#243) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add goci lint. (#243) * Add goci lint. Signed-off-by: xuezhaojun <zxue@redhat.com> * handle errs and remove unused. Signed-off-by: xuezhaojun <zxue@redhat.com> * fix fail and remove unused code. Signed-off-by: xuezhaojun <zxue@redhat.com> * Chore: Removed unused dockerfile cmd (#71) * chore: removed unused dockerfile cmd Signed-off-by: yue9944882 <291271447@qq.com> * passing IMAGE_TAG to make command Signed-off-by: yue9944882 <291271447@qq.com> * Patch status and finalizers (#244) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update file name to reflect the change in Makefile (#245) Signed-off-by: Lei Pan <leipan@ibm.com> * Upgrade go to 1.18 (#137) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Upgrade golang to 1.18 (#74) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Upgrade golang to 1.18 (#246) Also upgrade api library Signed-off-by: Jian Qiu <jqiu@redhat.com> * Upgrade go to 1.18 (#247) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add client cert condition when cert is rotated (#246) * Add client cert condition when cert is rotated Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix func name Signed-off-by: Jian Qiu <jqiu@redhat.com> * Upgrade library and api (#247) Signed-off-by: Jian Qiu <jqiu@redhat.com> * support labelselector set (#73) Signed-off-by: ldpliu <daliu@redhat.com> * Update binding status (#248) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Refector apply manifest code (#138) This is for the preparation of futher enhancement in work Signed-off-by: Jian Qiu <jqiu@redhat.com> * remove add default set label controller (#250) Signed-off-by: ldpliu <daliu@redhat.com> * remove set join permission for registration-controller (#248) Signed-off-by: ldpliu <daliu@redhat.com> * adapt label selector in clusterset (#242) Signed-off-by: ldpliu <daliu@redhat.com> * add global clusterset (#251) Signed-off-by: ldpliu <daliu@redhat.com> * use registration feature gates constants & variabels which in api repo (#253) Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Co-authored-by: ivan-cai <caijing.cai@alibaba-inc.com> * enable log flags (#249) Signed-off-by: Wei Liu <liuweixa@redhat.com> * enable log flags (#254) Signed-off-by: Wei Liu <liuweixa@redhat.com> * enable log flags (#140) Signed-off-by: Wei Liu <liuweixa@redhat.com> * update qps and burst (#249) Signed-off-by: ldpliu <daliu@redhat.com> * update default qps for webhook (#141) Signed-off-by: ldpliu <daliu@redhat.com> * support hubRegistrationFeatureGates and spokeRegistrationFeatureGates (#230) * support RegistrationFeatureGates in ClusterManager and Klusterlet Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * update to use DefaultHubRegistrationFeatureGates&DefaultSpokeRegistrationFeatureGates in api repo to check registration variable if valid Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * enable addonmanagement and defaultClusterset feature if RegistrationConfiguration is nil Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * fix some errors in unit test Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * add RegistrationFeatureGates to registration webhook Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Co-authored-by: caijing.cai <caijing.cai@alibaba-inc.com> * split registration permissions (#250) * split registration permissions Signed-off-by: haoqing0110 <qhao@redhat.com> * more comments Signed-off-by: haoqing0110 <qhao@redhat.com> * split registration permissions (#255) * split registration permissions Signed-off-by: haoqing0110 <qhao@redhat.com> * add more comments Signed-off-by: haoqing0110 <qhao@redhat.com> * split work permissions (#142) * split work permissions Signed-off-by: haoqing0110 <qhao@redhat.com> * add more comments Signed-off-by: haoqing0110 <qhao@redhat.com> * split work permissions (#252) * split work permissions Signed-off-by: haoqing0110 <qhao@redhat.com> * add more comments Signed-off-by: haoqing0110 <qhao@redhat.com> * keep appliedmanifestwork & clusterclaim CRDs when unstalling klusterlet (#255) Signed-off-by: Yang Le <yangle@redhat.com> * Support generate hub kubeconfigon on the management cluster for addons (#252) * Support generate hub kubeconfig on the management cluster for addons Signed-off-by: zhujian <jiazhu@redhat.com> * Add more comments Signed-off-by: zhujian <jiazhu@redhat.com> * Add unit test Signed-off-by: zhujian <jiazhu@redhat.com> * lint readme (#76) Signed-off-by: xuezhaojun <zxue@redhat.com> * clean resource before apply new (#257) * clean resource before apply new Signed-off-by: haoqing0110 <qhao@redhat.com> * update Signed-off-by: haoqing0110 <qhao@redhat.com> * leader election needs to operate configmaps and leases (#260) Signed-off-by: haoqing0110 <qhao@redhat.com> * add permisson for registration agent for running addon in hosted mode (#256) Signed-off-by: zhujian <jiazhu@redhat.com> * leader election needs to operate configmaps and leases (#261) Signed-off-by: haoqing0110 <qhao@redhat.com> * Use token request to sync sa (#259) * Use token request to sync sa Signed-off-by: Jian Qiu <jqiu@redhat.com> * Upgrade kind Signed-off-by: Jian Qiu <jqiu@redhat.com> * support update strategy in manifestwork (#139) * Add ssa strategy Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add test cases Signed-off-by: Jian Qiu <jqiu@redhat.com> * Resolve comments Signed-off-by: Jian Qiu <jqiu@redhat.com> * Use default manager in api repo Signed-off-by: Jian Qiu <jqiu@redhat.com> * Refatcor deleteOption patch ownerref separately for deleteOption Signed-off-by: Jian Qiu <jqiu@redhat.com> * Do not reconcile when ssa conflict Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add V1beta1CSRAPICompatibility feature gate for registration-controller (#259) * Add V1beta1CSRAPICompatibility feature gate for registration-controller Signed-off-by: Promacanthus <promacanthus@gmail.com> * Add csrInfo and update isSpokeClusterClientCertRenewal Signed-off-by: Promacanthus <promacanthus@gmail.com> * Rerun go mod vendor Signed-off-by: Promacanthus <promacanthus@gmail.com> * Register V1beta1CSRAPICompatibility and refacotr authorize function Signed-off-by: Promacanthus <promacanthus@gmail.com> * Update api dependency Signed-off-by: Promacanthus <promacanthus@gmail.com> * support add-on lease on management cluster (#260) Signed-off-by: Yang Le <yangle@redhat.com> * Add controller to sync image pull secret into addon namespaces. (#253) * add addon-controller Signed-off-by: xuezhaojun <zxue@redhat.com> * fix and add testcases Signed-off-by: xuezhaojun <zxue@redhat.com> * add test cases Signed-off-by: xuezhaojun <zxue@redhat.com> * add permission and change constant name Signed-off-by: xuezhaojun <zxue@redhat.com> * change permission Signed-off-by: xuezhaojun <zxue@redhat.com> * fix Signed-off-by: xuezhaojun <zxue@redhat.com> * add permission into addon-management clusterrole Signed-off-by: xuezhaojun <zxue@redhat.com> * split permission part into another PR Signed-off-by: xuezhaojun <zxue@redhat.com> * split permission part into another PR Signed-off-by: xuezhaojun <zxue@redhat.com> * split permission part into another PR Signed-off-by: xuezhaojun <zxue@redhat.com> * change annotation to labels Signed-off-by: xuezhaojun <zxue@redhat.com> * rename the pkg name Signed-off-by: xuezhaojun <zxue@redhat.com> * rename the pkg name Signed-off-by: xuezhaojun <zxue@redhat.com> * Add comments to explain why we keep sync secret in klusterlet-controller Signed-off-by: xuezhaojun <zxue@redhat.com> * add changelog for v0.8 (#77) Signed-off-by: haoqing0110 <qhao@redhat.com> * Add HubApiServerHostAlias for registration-agent and work-agent (#258) Signed-off-by: Bowen Zhu <Promacanthus@gmail.com> Add HubApiServerHostAlias for registration-agent and work-agent * add changelog v0.8 (#261) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add changelog for v0.8.0 (#143) Signed-off-by: Yang Le <yangle@redhat.com> * add v0.8 changelog (#263) Signed-off-by: Wei Liu <liuweixa@redhat.com> * fix release yaml (#264) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix release yaml (#263) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix release yaml (#144) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Allow OCM addons to setup metrics collection with Prometheus (#262) Related: stolostron/backlog#23547 Signed-off-by: mprahl <mprahl@users.noreply.github.com> * update libs (#266) Signed-off-by: Wei Liu <liuweixa@redhat.com> * upgrade go lib to the latest version and bump csv to 0.9.0 (#265) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * upgrade the go libraries to latest version (#78) Signed-off-by: haoqing0110 <qhao@redhat.com> * upgrade go libraries (#145) Signed-off-by: Yang Le <yangle@redhat.com> * recreate the hub kubeconfig when addon deploy option changes (#265) * recreate the hub kubeconfig when addon deploy option changes Signed-off-by: zhujian <jiazhu@redhat.com> * put addon agent install option into hash Signed-off-by: zhujian <jiazhu@redhat.com> * put addonInstallOption inline in registrationConfig Signed-off-by: zhujian <jiazhu@redhat.com> * check e2e mutatingWebhookDeployment replicas (#267) Signed-off-by: haoqing0110 <qhao@redhat.com> * Refactor to split two controllers to handle klusterlet deployment and cleanup (#269) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Apply only when having finalizer (#270) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * move apply method to seperate package (#149) * move apply method to seperate package Signed-off-by: Jian Qiu <jqiu@redhat.com> * make sure the update apply func returns existing object Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> Co-authored-by: Jian Qiu <jqiu@redhat.com> * Use the correct managed cluster name in the apply-spoke-cr-hosted target (#266) Signed-off-by: mprahl <mprahl@users.noreply.github.com> Signed-off-by: mprahl <mprahl@users.noreply.github.com> * reduce log print (#269) Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com> * fix Missing filter (#151) Signed-off-by: tytao <1522014784@qq.com> Signed-off-by: tytao <1522014784@qq.com> * update serverURL and CABundle if ManagedCluster is created before reg… (#270) * update serverURL and CABundle if ManagedCluster is created before registration-agent running Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * merge spokeExternalServerURLs to ManagedClusterClientConfigs, and ingnore Unauthorized error Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * add comment for skipping unauthorized error, and skip unauthorized error when creating ManagedCluster Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * use skipUnauthorizedError at creating controller Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * Fix nil pointer panic (#157) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * update add-on configuration apis (#272) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * Disable placement scheduling (#80) * Disable placement scheduling Signed-off-by: clyang82 <chuyang@redhat.com> * Update to use annontation defined in api Signed-off-by: clyang82 <chuyang@redhat.com> * sync to vendor folder Signed-off-by: clyang82 <chuyang@redhat.com> * run go mod tidy Signed-off-by: clyang82 <chuyang@redhat.com> * sync-up deploy/hub Signed-off-by: clyang82 <chuyang@redhat.com> Signed-off-by: clyang82 <chuyang@redhat.com> * add skip-remove-crds option for cluster-manager, to choose if skip removing CRDs when ClusterManager is deleting (#274) Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> * Allow work agent to create subjectaccessreviews (#273) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * check the executor subject permission for action apply (#152) * check work execution permission Signed-off-by: zhujian <jiazhu@redhat.com> * Move requeue time in auth package Signed-off-by: zhujian <jiazhu@redhat.com> * fix flaky test Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * decouple bootstrap informers to distinguish the lifecycle (#271) Signed-off-by: yue9944882 <291271447@qq.com> Signed-off-by: yue9944882 <291271447@qq.com> * Allow work agent to impersonate serviceaccount (#275) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * add PlacementConditionMisconfigured (#72) * add PlacementConditionMisconfigured Signed-off-by: haoqing0110 <qhao@redhat.com> * add testing cases Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * Make work webhook feature gate configurable (#276) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * trigger sync when cluster belongs to LabelSelector type clusterset (#81) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * Fix: delete addon crd at first (#277) This is to ensure manifestwork of addon is deleted at first. Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * validate manifest work executor permission on hub cluster (#158) * validate manifest work executor permission on hub cluster Signed-off-by: zhujian <jiazhu@redhat.com> * do not validate the executor when it is not changed Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * check escalation for executor subject (#159) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * check the executor subject permission for delete (#160) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * remove API Placement PlacementDecision ClusterSet ClusterSetBinding API version v1alpha1 (#278) * remove API Placement PlacementDecision ClusterSet ClusterSetBinding API version v1alpha1 Signed-off-by: haoqing0110 <qhao@redhat.com> * check migration status before update CRD stored version Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * add conversion webhook to convert clusterset api (#272) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * add conversion webhook (#279) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * update clusterrole in olm-catalog (#281) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * remove clusterrole/role cleanBeforeApply code added in ocm 0.8.0 (#283) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * Remove install mode detached (#282) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Fix token path in hosted mode (#284) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * stop to discovery addon when its managed cluster is not found (#274) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * fix conversion webhook in hosted mode (#280) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * remove the support for checking add-on hub lease (#275) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * add v0.9 changelog (#276) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * add changelog 0.9 (#285) Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add changelog for v0.9.0 (#162) Signed-off-by: Yang Le <yangle@redhat.com> Signed-off-by: Yang Le <yangle@redhat.com> * add changelog for v0.9 (#83) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * update golang to 1.19 (#279) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * correct managed cluster lease name (#287) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * upgrade go to 1.19 (#286) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * upgrade to golang1.19 (#163) Signed-off-by: Yang Le <yangle@redhat.com> Signed-off-by: Yang Le <yangle@redhat.com> * Upgrade golang to 1.19 (#84) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * bump to 0.10.0 (#291) Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com> * Avoid frequent CSR creation (#277) * Avoid frequent CSR creation Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add todo for threshold value Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix the paradox description of the klusterlet condition (#290) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * update changelog 0.9.1 (#295) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * rewrite webhook using controller runtime (#278) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * Add owner (#86) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * Delete unmanaged AppliedManifestWork (#161) * Delete unmanaged AppliedManifestWork Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add integration test Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * ensure a cluster lease is updated after the cluster is restored (#280) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * Add SetExternalKubeClientSet to allow injecting to APIServer's admission (#281) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * use controller runtime to implement webhook (#164) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * upgrade appliedmanifestwork API (#298) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * update clustermanangementaddon api (#300) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * fix validating webhook (#282) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * Upgrade ginkgo to v2. (#283) Signed-off-by: xuezhaojun <zxue@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> * Upgrade ginkgo to v2. (#301) Signed-off-by: xuezhaojun <zxue@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> * set min tls version (#284) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * set min tls version (#166) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * use controller-runtime webhook (#293) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * upgrade clusterset api to v1beta2 (#82) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * upgrade clusterset api to v1beta2 (#273) Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> * Update ginkgo to v2 (#88) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Update ginkgo to v2 (#168) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * exclude add-on csrs (#286) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * cache the executor validation results (#165) * cache the executor validation results Signed-off-by: zhujian <jiazhu@redhat.com> * move executor cache controller to auth package Signed-off-by: zhujian <jiazhu@redhat.com> * add a binding resource executor mapper to process delete event Signed-off-by: zhujian <jiazhu@redhat.com> * initialize caches before starting the cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * read enable executor caches from flag Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache store Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache validator Signed-off-by: zhujian <jiazhu@redhat.com> * add unit tests for cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * read enable executor caches from feature gate Signed-off-by: zhujian <jiazhu@redhat.com> * add integration tests for cache controller Signed-off-by: zhujian <jiazhu@redhat.com> * add a description doc for the cache package Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Refactor clustermanager controller (#305) * Refactor clustermanager controller Signed-off-by: Jian Qiu <jqiu@redhat.com> * Refactor cond update Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Refactor klusterlet (#306) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Refactor integration test (#90) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Make work agent feature gate configurable (#303) * Make work agent feature gate configurable Signed-off-by: zhujian <jiazhu@redhat.com> * Merge registration and work feature gate conditions Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * watch placementscore during scheduling (#89) * watch placementscore during scheduling refactor eventhandler using index Signed-off-by: Jian Qiu <jqiu@redhat.com> * Filter placement when enqueue score Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add integration tests (#91) Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Delete resource even if it has non-appliedmanifestwork owners (#170) * Delete resource even if it has non-appliedmanifestwork owners Signed-off-by: zhujian <jiazhu@redhat.com> * Make tests easier to debug Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> * Reduce default sync interval to 10s (#167) Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add integration tests (#93) Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * upgrade github action (#94) Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> * Add test case for hubConfigSecretMissing case. (#307) Signed-off-by: xuezhaojun <zxue@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> * upgrade github action (#308) Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> * upgrade github action (#289) Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> * using requeue cluster instead of resync lease controller (#288) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * roll back code to support lower version k8s (#291) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * use crd manager to update and clean crds (#297) * use crd manager to update clean crds Signed-off-by: Jian Qiu <jqiu@redhat.com> * Update tests Signed-off-by: Jian Qiu <jqiu@redhat.com> * Rebase crd manager Signed-off-by: Jian Qiu <jqiu@redhat.com> * build client builder to make code clearer Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add ut for crdmanager Signed-off-by: Jian Qiu <jqiu@redhat.com> * Compare crd spec when update Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Add OAuthClient permissions to klusterlet-work-clusterrole-execution (#310) Signed-off-by: Jon Jackson <jonjacks@redhat.com> Signed-off-by: Jon Jackson <jonjacks@redhat.com> * create empty decision when no cluster selected (#95) * create empty decision when no cluster selected Signed-off-by: haoqing0110 <qhao@redhat.com> * create placementdecision when misconfigured Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> * delete old applied work after its new work is applied (#172) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * clear the comments for deleting unmanaged appliedmanifestworks (#174) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> * Add inital skeleton for placeManifestWork controller (#171) * Add inital skeleton for placeManifestWork controller Signed-off-by: melserngawy <melserng@redhat.com> * Update vendor Signed-off-by: melserngawy <melserng@redhat.com> * fix pkgs Signed-off-by: melserngawy <melserng@redhat.com> Signed-off-by: melserngawy <melserng@redhat.com> * Add informer setup for placemanifestwork (#175) - add index and informer to watch resources - build binary for hub manager Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Split logic of controller to multiple reconcilers (#176) This could make code clearer also update the crd fix Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> * Allow customizing the klusterlet name when deploying in hosted mode (#311) This will allow users of this Makefile to deploy multiple managed clusters in hosted mode. Signed-off-by: mprahl <mprahl@users.noreply.github.com> Signed-off-by: mprahl <mprahl@users.noreply.github.com> * cleanup return if appliedmainfestWork is notfound (#312) Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com> * use labels in api repo (#290) Signed-off-by: Jian Qiu <jqiu@redhat.com> * add v0.10 changelog (#292) Signed-off-by: Wei Liu <liuweixa@redhat.com> * add changelog v0.10 (#313) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * add changelog for v0.10.0 (#179) Signed-off-by: Yang Le <yangle@redhat.com> * add changelog for v0.10.0 (#97) Signed-off-by: haoqing0110 <qhao@redhat.com> * upgrade image builder (#314) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * update imagebuilder (#293) Signed-off-by: Wei Liu <liuweixa@redhat.com> * upgrade imagebuilder (#181) Signed-off-by: Yang Le <yangle@redhat.com> * Add create,update and delete placeManifestWork (#177) Signed-off-by: melserngawy <melserng@redhat.com> * Bump github.com/emicklei/go-restful (#296) Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v2.9.5...v2.16.0) --- updated-dependencies: - dependency-name: github.com/emicklei/go-restful dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/emicklei/go-restful (#183) Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v2.9.5...v2.16.0) --- updated-dependencies: - dependency-name: github.com/emicklei/go-restful dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/emicklei/go-restful (#317) Bumps [github.com/emicklei/go-restful](https://github.com/emicklei/go-restful) from 2.9.5+incompatible to 2.16.0+incompatible. - [Release notes](https://github.com/emicklei/go-restful/releases) - [Changelog](https://github.com/emicklei/go-restful/blob/v3/CHANGES.md) - [Commits](emicklei/go-restful@v2.9.5...v2.16.0) --- updated-dependencies: - dependency-name: github.com/emicklei/go-restful dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * regenerate and load hosted secrets when ca changes (#316) Signed-off-by: zhujian <jiazhu@redhat.com> * clusterset v1beta1 migration (#315) Signed-off-by: ldpliu <daliu@redhat.com> * use latest api to migrate clusterset (#297) Signed-off-by: ldpliu <daliu@redhat.com> * update imagebuilder (#98) Signed-off-by: haoqing0110 <qhao@redhat.com> * Remove anonymous check from managedClusterCreatingController sync (#299) Signed-off-by: aii-nozomu-oki <h-nozomu.oki@inside.ai> * Add validate webhook (#182) Signed-off-by: melserngawy <melserng@redhat.com> * bump v0.11.0 (#320) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * Add initial e2e/integration for placeManifestWork (#180) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Bump golang.org/x/net from 0.2.0 to 0.7.0 (#300) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.2.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.2.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.1.0 to 0.7.0 (#184) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.1.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.1.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Upgrade mca/cma APIs (#324) Signed-off-by: Jian Qiu <jqiu@redhat.com> * Bump golang.org/x/net from 0.1.0 to 0.7.0 (#323) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.1.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.1.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/crypto from 0.0.0-20220214200702-86341886e292 to 0.1.0 (#326) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20220214200702-86341886e292 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Do not filter applied manifest work by hub host when deleting klusterlet (#321) Signed-off-by: zhujian <jiazhu@redhat.com> * fix migration issue (#328) Signed-off-by: ldpliu <daliu@redhat.com> * the manifest size limit can be configured (#186) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * Rename placeManifestWork to manifestWorkReplicaSet (#187) * Rename placeManifestWork to manifestWorkReplicaSet Signed-off-by: melserngawy <melserng@redhat.com> * Rename apis and variables Signed-off-by: melserngawy <melserng@redhat.com> --------- Signed-off-by: melserngawy <melserng@redhat.com> * Bump golang.org/x/crypto from 0.0.0-20220214200702-86341886e292 to 0.1.0 (#188) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20220214200702-86341886e292 to 0.1.0. - [Release notes](https://github.com/golang/crypto/releases) - [Commits](https://github.com/golang/crypto/commits/v0.1.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * upgrade kube lib to 1.26 (#100) Signed-off-by: haoqing0110 <qhao@redhat.com> * upgrade kube lib to 1.26 (#329) Signed-off-by: Zhiwei Yin <zyin@redhat.com> * remove old webhook (#330) Signed-off-by: ldpliu <daliu@redhat.com> * upgrade kube to 1.26 (#302) Signed-off-by: Wei Liu <liuweixa@redhat.com> * Upgrade kube lib to 1.26 and remove old webhook (#189) Signed-off-by: Jian Qiu <jqiu@redhat.com> * addon manager feature gates (#325) Signed-off-by: haoqing0110 <qhao@redhat.com> * Remove: work directory in github action. (#303) Signed-off-by: xuezhaojun <zxue@redhat.com> * make e2e test cases ran as canary test cases (#178) Signed-off-by: Yang Le <yangle@redhat.com> * Add manifestWorkReplicaSet feature check (#192) Signed-off-by: melserngawy <melserng@redhat.com> * appliedmanifestwork eviction (#190) Signed-off-by: Wei Liu <liuweixa@redhat.com> * Add e2e/integration test case for manifestworkreplicaset (#191) * Add e2e/integration test case for manifestworkreplicaset Signed-off-by: Jian Qiu <jqiu@redhat.com> * Fix rbac in e2e test Signed-off-by: Jian Qiu <jqiu@redhat.com> --------- Signed-off-by: Jian Qiu <jqiu@redhat.com> * Validate metadata.name of managed cluster (#304) Signed-off-by: Jian Qiu <jqiu@redhat.com> * ci: build multi-arch image (#101) Signed-off-by: zhujian <jiazhu@redhat.com> * refactor migration and storedversion update (#332) Signed-off-by: ldpliu <daliu@redhat.com> * Move orgin OCM files into /origin-ocm Signed-off-by: xuezhaojun <zxue@redhat.com> * Upgrade dependencies. (#103) Signed-off-by: xuezhaojun <zxue@redhat.com> * Upgrade deps. (#194) Signed-off-by: xuezhaojun <zxue@redhat.com> * Upgrade dependencies. (#333) Signed-off-by: xuezhaojun <zxue@redhat.com> * Upgrade dependencies. (#305) Signed-off-by: xuezhaojun <zxue@redhat.com> * Save origin OCM files. Signed-off-by: xuezhaojun <zxue@redhat.com> * relocate to staing: registration Signed-off-by: xuezhaojun <zxue@redhat.com> * relocate to staing: work Signed-off-by: xuezhaojun <zxue@redhat.com> * relocate to staing: placement Signed-off-by: xuezhaojun <zxue@redhat.com> * relocate to staing: registration-operator Signed-off-by: xuezhaojun <zxue@redhat.com> * Add: build images of core repos. Signed-off-by: xuezhaojun <zxue@redhat.com> * Move origin OCM files back. Signed-off-by: xuezhaojun <zxue@redhat.com> --------- Signed-off-by: Yang Le <yangle@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Jian Qiu <jqiu@redhat.com> Signed-off-by: haoqing0110 <qhao@redhat.com> Signed-off-by: zhujian <jiazhu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: yue9944882 <291271447@qq.com> Signed-off-by: panguicai008 <1121906548@qq.com> Signed-off-by: Mike Ng <ming@redhat.com> Signed-off-by: xuezhaojun <zxue@redhat.com> Signed-off-by: Lei Pan <leipan@ibm.com> Signed-off-by: Promacanthus <promacanthus@gmail.com> Signed-off-by: mprahl <mprahl@users.noreply.github.com> Signed-off-by: tytao <1522014784@qq.com> Signed-off-by: ivan-cai <caijing.cai@alibaba-inc.com> Signed-off-by: clyang82 <chuyang@redhat.com> Signed-off-by: ycyaoxdu <yaoyuchen0626@163.com> Signed-off-by: Jon Jackson <jonjacks@redhat.com> Signed-off-by: melserngawy <melserng@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: aii-nozomu-oki <h-nozomu.oki@inside.ai> Co-authored-by: Yang Le <yangle@redhat.com> Co-authored-by: Zhiwei Yin <zyin@redhat.com> Co-authored-by: Wei Liu <liuweixa@redhat.com> Co-authored-by: Jian Qiu <jqiu@redhat.com> Co-authored-by: Qing Hao <qhao@redhat.com> Co-authored-by: Jian Zhu <36154065+zhujian7@users.noreply.github.com> Co-authored-by: DangPeng Liu <daliu@redhat.com> Co-authored-by: Min Kim <291271447@qq.com> Co-authored-by: panguicai <guicai.pan@daocloud.io> Co-authored-by: Mike Ng <ming@redhat.com> Co-authored-by: Lei P <leipan@ibm.com> Co-authored-by: ivanscai <jcaiwork@163.com> Co-authored-by: ivan-cai <caijing.cai@alibaba-inc.com> Co-authored-by: Bowen Zhu <Promacanthus@gmail.com> Co-authored-by: Matt Prahl <mprahl@users.noreply.github.com> Co-authored-by: TYTaO <1522014784@qq.com> Co-authored-by: Chunlin Yang <chuyang@redhat.com> Co-authored-by: Yuchen YAO <37959723+ycyaoxdu@users.noreply.github.com> Co-authored-by: Jon Jackson <jonjacks@redhat.com> Co-authored-by: Mohamed ElSerngawy <melserng@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ohki Nozomu <114966641+aii-nozomu-oki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ycyaoxdu yaoyuchen0626@163.com