Add to argocd documentation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omar Farag <ofarag@redhat.com>
mikeshng
reviewed
May 30, 2023
| @@ -32,6 +32,44 @@ Your IP address is usually next to the last entry of 'inet'. An IP address is al | |||
| cluster1 true https://cluster1-control-plane:6443 18s | |||
| cluster2 true https://cluster2-control-plane:6443 1s | |||
| ``` | |||
| <details> | |||
| <summary>Known issue when running setup script</summary> | |||
There was a problem hiding this comment.
Suggested change
| <summary>Known issue when running setup script</summary> | |
| <summary>Known issue when running the setup script on a Linux environment</summary> |
Signed-off-by: Omar Farag <ofarag@redhat.com>
Signed-off-by: Omar Farag <ofarag@redhat.com>
|
@mikeshng I also added it to https://github.com/open-cluster-management-io/ocm/tree/main/solutions/setup-dev-environment since it has a similar setup script |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, o-farag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clyang82
pushed a commit
to clyang82/ocm
that referenced
this pull request
Jun 2, 2023
Signed-off-by: tytao <1522014784@qq.com> Signed-off-by: tytao <1522014784@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble trying to follow this documentation because I couldn't complete the
./setup-ocm.shstep. It took me a while to figure out the solution, hopefully this can help others who may run into the same issue.