✨ set agent install namespace from addon deployment config for template type addons #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 60.73% 60.91% +0.18%
==========================================
Files 128 128
Lines 13685 13682 -3
==========================================
+ Hits 8311 8335 +24
+ Misses 4608 4584 -24
+ Partials 766 763 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zhujian7
force-pushed
the
addon-install-ns
branch
2 times, most recently
from
8b0e30c to
ad824d3
Compare
zhujian7
changed the title
zhujian7
force-pushed
the
addon-install-ns
branch
4 times, most recently
from
62e90d9 to
4377185
Compare
|
/hold |
zhujian7
force-pushed
the
addon-install-ns
branch
3 times, most recently
from
a372af7 to
e9a4a6c
Compare
… type addons Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
addon-install-ns
branch
from
e9a4a6c to
c524ca7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set agent install namespace from addon deployment config for template type addons, so for template type addons, users can use the addonDeploymentConfig API to configure the agent install namespace.
Related issue(s)
Fixes #