🐛: remove managedclustersetbinding v1beta1 in webhook. #316
Conversation
xuezhaojun
force-pushed
the
removal-managedclustersetbindingv1beta1-webhook
branch
from
01c5a13
to
b4330d9
Compare
| @@ -22,6 +22,6 @@ webhooks: | |||
| - v1beta2 | |||
| resources: | |||
| - managedclustersetbindings | |||
| admissionReviewVersions: ["v1beta1","v1"] | |||
| admissionReviewVersions: ["v1beta2","v1"] | |||
There was a problem hiding this comment.
seems the admissionReviewVersions is not related to the to-be-validated resources version? Not sure if we should change this.
There was a problem hiding this comment.
In fact, this list is not used in our customized webhook logic, the only field we leverage is UserInfo:
So in this configuration, we can put any version for example "v2". We change it to v1beta2 just to aglin with our version migration progress.
There was a problem hiding this comment.
this is the version of admissionReview, not the version of crd.
There was a problem hiding this comment.
this should not be changed to v1beta2
There was a problem hiding this comment.
Got it, changed back.
xuezhaojun
force-pushed
the
removal-managedclustersetbindingv1beta1-webhook
branch
2 times, most recently
from
fbbd9fe
to
98a8d86
Compare
|
/assign @zhujian7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 61.78% 61.78%
=======================================
Files 132 132
Lines 13983 13983
=======================================
Hits 8640 8640
+ Misses 4579 4578 -1
- Partials 764 765 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xuezhaojun
force-pushed
the
removal-managedclustersetbindingv1beta1-webhook
branch
from
98a8d86
to
95d7924
Compare
|
/assign @qiujian16 |
Signed-off-by: xuezhaojun <zxue@redhat.com>
xuezhaojun
force-pushed
the
removal-managedclustersetbindingv1beta1-webhook
branch
from
95d7924
to
4a4986a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a46086d
into
open-cluster-management-io:main
xuezhaojun
deleted the
removal-managedclustersetbindingv1beta1-webhook
branch
…gement-io#316) Signed-off-by: zhujian <jiazhu@redhat.com>
…luster-management-io#316) Signed-off-by: Jian Qiu <jqiu@redhat.com>
Summary
We have split the webhook configuration of managedclustersetbinding to 2 configs in this PR: open-cluster-management-io/registration-operator#293
The previous release are not affected and all functionalities are fine, just remove v1beta1 content to make versions more clear.
Related issue(s)
Fixes #