Open API Update - Sync with Open API PR 249 #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindkrishnakumar-okta
changed the base branch from
master
to
dev_openapi_v2.0.0_major_rel
Codecov Report
@@ Coverage Diff @@
## dev_openapi_v2.0.0_major_rel #420 +/- ##
===============================================================
Coverage 71.63% 71.63%
Complexity 1147 1147
===============================================================
Files 122 122
Lines 3705 3705
Branches 570 570
===============================================================
Hits 2654 2654
Misses 863 863
Partials 188 188 Continue to review full report at Codecov.
|
|
Looks good, but we should probably add a test to make sure the dates get formatted correctly: https://github.com/okta/okta-sdk-java/blob/dev_openapi_v2.0.0_major_rel/impl/src/test/groovy/com/okta/sdk/impl/resource/log/LogsTest.groovy#L44 |
Added UTs. |
bdemers
reviewed
Jun 24, 2020
impl/src/test/groovy/com/okta/sdk/impl/resource/log/LogsTest.groovy
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Jun 25, 2020
impl/src/test/groovy/com/okta/sdk/impl/resource/log/LogsTest.groovy
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Jun 29, 2020
impl/src/test/groovy/com/okta/sdk/impl/ds/DefaultCacheKeyTest.groovy
Outdated
Show resolved
Hide resolved
bdemers
approved these changes
Jun 29, 2020
…groovy Co-authored-by: Brian Demers <bdemers@apache.org>
Addressed this. |
arvindkrishnakumar-okta
added a commit
that referenced
this pull request
Jul 7, 2020
* upgrade to openapi v2.0.0 (#380) * openapi spec update - remove 200 response from generateCsrForApplication * Update OktaOrgCleaner.groovy * Fix flaky GroupsIT#groupUserOperationsTest test * Update GroupsIT.groovy * OKTA-279039: Fix flaky ApplicationsIT associateUserWithApplication test * Update GroupsIT.groovy * Addressed review comment * OKTA-289656: Add Applications API Integration Tests * OKTA-289655: Add Admin role API Integration Tests * Open API Csr rename update (#394) * openapi csr rename update * Merge pull request #396 * revert csr model rename (#398) * revert csr model rename * open api spec update (#401) * open api spec update * Open API spec - fix binding enum value for ProtocolEndpoint model (#406) * OKTA-289662: Add SMS Templates API Integration Tests (#395) * OKTA-289665: Add Linked Objects Integration Tests (#404) * Updated Licence Header in LinkedObjectsIT (#410) * OKTA-289668: Add User Type Integration Tests (#405) * Open API Update - Sync with #238 #239 (#411) * sync with open api pr #240 (#413) * Open API Update - Sync with #241 (#412) * Open API Update - Sync with #242 (#414) * Open API Update - Sync with Open API PR 243 (#416) * OKTA-289657: Add Factors API Integration Tests (#391) * OKTA-289659: Add Event Hooks Integration Tests (#399) * OKTA-289659: Add Authorization Server Integration Tests (#402) * OKTA-289660: Add Inline Hooks Integration Tests (#400) * Open API Update - Sync with Open API PR 244 (#418) * fixed copy paste error * OKTA-289661: Add Feature API Integration Tests (#397) * Open API Update - Sync with Open API PR 249 (#420) * OKTA-289663: Add IdP Integration Tests (#409) * resolved merge conflicts with master changes * removed Default prefix from few Idp builders * added swagger code gen check for backward compatibility requirements per review comments * fixed findbugs error * updates per swagger regen code and one other update to Idp builder * fixed expiresAt param type in spec * deprecated old classes * refactored InlineHooksIT - deactivate created hooks so it can be cleaned up after test * Remove deprecated code (#426) * Remove deprecated code * fix typo * fixed PMD violation - unused inports * Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/CrudTestSupport.groovy Co-authored-by: Brian Demers <bdemers@apache.org> * Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/FactorsIT.groovy Co-authored-by: Brian Demers <bdemers@apache.org> * Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/UsersIT.groovy Co-authored-by: Brian Demers <bdemers@apache.org> * Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/GroupsIT.groovy Co-authored-by: Brian Demers <bdemers@apache.org> * minor improvements (#427) * OKTA-308935: Create Migration Guide for Java Mgmt SDK v2.0.0 (#423) Co-authored-by: Ivan Ezeigbo <56391095+ivanezeigbo-okta@users.noreply.github.com> Co-authored-by: Brian Demers <bdemers@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Description
TODO: Cut tag
1.2.4out ofokta-commons.Category