Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YAML dependency optional #241

Closed
robertjd opened this issue Dec 10, 2018 · 2 comments
Closed

Make YAML dependency optional #241

robertjd opened this issue Dec 10, 2018 · 2 comments
Milestone
1.4.0

Comments

@robertjd
Copy link

Refactor the snake YAML dependency to be optional, in such a way that okta-auth-java will not have a hard dependency on that library.
@bdemers
Copy link
Contributor

bdemers commented Dec 10, 2018

There are a couple of touch points that I can think of where we parse YAML files:

  • Loading config from ~/.okta/okta.yaml (don't parse this file if the YAML parser is not available)
  • Default configuration classpath:com/okta/authn/sdk/config/okta.yaml (switch to a json or properties format, or set the defaults programmatically)
  • The class: com.okta.sdk.impl.ds.DiscriminatorConfig (not 100% sure on this one, switching to json might be a quick win, This code path might be executed when the auth-sdk is trying to figure out the factor type to marshal/unmarshal)

@bdemers bdemers added the Triaged label Jan 7, 2019
@bdemers
Copy link
Contributor

bdemers commented Jan 15, 2019

Fixed by #243 and #445

@bdemers bdemers closed this as completed Jan 15, 2019
@bdemers bdemers removed the Triaged label Jan 15, 2019
@bdemers bdemers added this to the 1.4.0 milestone Jan 17, 2019
arvindkrishnakumar-okta added a commit that referenced this issue Jun 12, 2020
@arvindkrishnakumar-okta
Open API Update - Sync with #241
5cc1e06
arvindkrishnakumar-okta added a commit that referenced this issue Jun 15, 2020
@arvindkrishnakumar-okta
Open API Update - Sync with #241 (#412)
d5d755d
arvindkrishnakumar-okta added a commit that referenced this issue Jul 7, 2020
@arvindkrishnakumar-okta @ivanezeigbo-okta @bdemers
OKTA-302317: Release Java Mgmt SDK v2.0.0 (#422)
03cabad 
* upgrade to openapi v2.0.0 (#380)

* openapi spec update - remove 200 response from generateCsrForApplication

* Update OktaOrgCleaner.groovy

* Fix flaky GroupsIT#groupUserOperationsTest test

* Update GroupsIT.groovy

* OKTA-279039: Fix flaky ApplicationsIT associateUserWithApplication test

* Update GroupsIT.groovy

* Addressed review comment

* OKTA-289656: Add Applications API Integration Tests

* OKTA-289655: Add Admin role API Integration Tests

* Open API Csr rename update (#394)

* openapi csr rename update

* Merge pull request #396

* revert csr model rename (#398)

* revert csr model rename

* open api spec update (#401)

* open api spec update

* Open API spec - fix binding enum value for ProtocolEndpoint model (#406)

* OKTA-289662: Add SMS Templates API Integration Tests (#395)

* OKTA-289665: Add Linked Objects Integration Tests (#404)

* Updated Licence Header in LinkedObjectsIT (#410)

* OKTA-289668: Add User Type Integration Tests (#405)

* Open API Update - Sync with #238 #239  (#411)

* sync with open api pr #240 (#413)

* Open API Update - Sync with #241 (#412)

* Open API Update - Sync with #242 (#414)

* Open API Update - Sync with Open API PR 243 (#416)

* OKTA-289657: Add Factors API Integration Tests (#391)

* OKTA-289659: Add Event Hooks Integration Tests (#399)

* OKTA-289659: Add Authorization Server Integration Tests (#402)

* OKTA-289660: Add Inline Hooks Integration Tests (#400)

* Open API Update - Sync with Open API PR 244 (#418)

* fixed copy paste error

* OKTA-289661: Add Feature API Integration Tests (#397)

* Open API Update - Sync with Open API PR 249 (#420)

* OKTA-289663: Add IdP Integration Tests (#409)

* resolved merge conflicts with master changes

* removed Default prefix from few Idp builders

* added swagger code gen check for backward compatibility requirements per review comments

* fixed findbugs error

* updates per swagger regen code and one other update to Idp builder

* fixed expiresAt param type in spec

* deprecated old classes

* refactored InlineHooksIT - deactivate created hooks so it can be cleaned up after test

* Remove deprecated code (#426)

* Remove deprecated code

* fix typo

* fixed PMD violation - unused inports

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/CrudTestSupport.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/FactorsIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/UsersIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/GroupsIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* minor improvements (#427)

* OKTA-308935: Create Migration Guide for Java Mgmt SDK v2.0.0 (#423)

Co-authored-by: Ivan Ezeigbo <56391095+ivanezeigbo-okta@users.noreply.github.com>
Co-authored-by: Brian Demers <bdemers@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@bdemers @robertjd