Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKTA-289663: Add IdP Integration Tests #409

Merged
merged 19 commits into from
Jun 29, 2020
Merged

OKTA-289663: Add IdP Integration Tests #409

merged 19 commits into from
Jun 29, 2020

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Jun 11, 2020 •
edited
Loading

Issue(s)

OKTA-289663

Description

Add Integration Tests for IdP API.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Configuration Change
  • Versioning Change
  • Unit Test(s)
  • Documentation

@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title OKTA-289663: Add IdP Integration Tests [WIP] OKTA-289663: Add IdP Integration Tests Jun 11, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta marked this pull request as draft June 11, 2020 17:01
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title [WIP] OKTA-289663: Add IdP Integration Tests OKTA-289663: Add IdP Integration Tests Jun 11, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta marked this pull request as ready for review June 11, 2020 22:02
bdemers
bdemers reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If updates are supported for the IdP endpoints we should add a test for that too.
(listing them as well)

@arvindkrishnakumar-okta
Copy link
Contributor Author

If updates are supported for the IdP endpoints we should add a test for that too.
(listing them as well)

Done, ready for review.

@bdemers
Copy link
Contributor

bdemers commented Jun 19, 2020

Can you add a minimal test for a named IdP like google? I'm assuming it should only need the type, client id/secret, and scopes

@arvindkrishnakumar-okta
Copy link
Contributor Author

Can you add a minimal test for a named IdP like google? I'm assuming it should only need the type, client id/secret, and scopes

sure, will do.

@arvindkrishnakumar-okta
Copy link
Contributor Author

Can you add a minimal test for a named IdP like google? I'm assuming it should only need the type, client id/secret, and scopes

sure, will do.

done, updated PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #409 into dev_openapi_v2.0.0_major_rel will increase coverage by 1.65%.
The diff coverage is 99.57%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##             dev_openapi_v2.0.0_major_rel     #409      +/-   ##
==================================================================
+ Coverage                           71.63%   73.29%   +1.65%     
- Complexity                           1147     1186      +39     
==================================================================
  Files                                 122      128       +6     
  Lines                                3705     3939     +234     
  Branches                              570      570              
==================================================================
+ Hits                                 2654     2887     +233     
- Misses                                863      864       +1     
  Partials                              188      188
Impacted Files Coverage Δ Complexity Δ
...ntity/provider/DefaultIdentityProviderBuilder.java 95.00% <95.00%> (ø) 11.00 <11.00> (?)
...ovider/DefaultFacebookIdentityProviderBuilder.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...provider/DefaultGoogleIdentityProviderBuilder.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...ovider/DefaultLinkedInIdentityProviderBuilder.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...vider/DefaultMicrosoftIdentityProviderBuilder.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...y/provider/DefaultOIDCIdentityProviderBuilder.java 100.00% <100.00%> (ø) 20.00 <20.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d59723e...2f0a245. Read the comment docs.

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 8175213 into dev_openapi_v2.0.0_major_rel Jun 29, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the okta-289663-add-idp-integration-tests branch June 29, 2020 20:23
arvindkrishnakumar-okta added a commit that referenced this pull request Jul 7, 2020
@arvindkrishnakumar-okta @ivanezeigbo-okta @bdemers
OKTA-302317: Release Java Mgmt SDK v2.0.0 (#422)
03cabad 
* upgrade to openapi v2.0.0 (#380)

* openapi spec update - remove 200 response from generateCsrForApplication

* Update OktaOrgCleaner.groovy

* Fix flaky GroupsIT#groupUserOperationsTest test

* Update GroupsIT.groovy

* OKTA-279039: Fix flaky ApplicationsIT associateUserWithApplication test

* Update GroupsIT.groovy

* Addressed review comment

* OKTA-289656: Add Applications API Integration Tests

* OKTA-289655: Add Admin role API Integration Tests

* Open API Csr rename update (#394)

* openapi csr rename update

* Merge pull request #396

* revert csr model rename (#398)

* revert csr model rename

* open api spec update (#401)

* open api spec update

* Open API spec - fix binding enum value for ProtocolEndpoint model (#406)

* OKTA-289662: Add SMS Templates API Integration Tests (#395)

* OKTA-289665: Add Linked Objects Integration Tests (#404)

* Updated Licence Header in LinkedObjectsIT (#410)

* OKTA-289668: Add User Type Integration Tests (#405)

* Open API Update - Sync with #238 #239  (#411)

* sync with open api pr #240 (#413)

* Open API Update - Sync with #241 (#412)

* Open API Update - Sync with #242 (#414)

* Open API Update - Sync with Open API PR 243 (#416)

* OKTA-289657: Add Factors API Integration Tests (#391)

* OKTA-289659: Add Event Hooks Integration Tests (#399)

* OKTA-289659: Add Authorization Server Integration Tests (#402)

* OKTA-289660: Add Inline Hooks Integration Tests (#400)

* Open API Update - Sync with Open API PR 244 (#418)

* fixed copy paste error

* OKTA-289661: Add Feature API Integration Tests (#397)

* Open API Update - Sync with Open API PR 249 (#420)

* OKTA-289663: Add IdP Integration Tests (#409)

* resolved merge conflicts with master changes

* removed Default prefix from few Idp builders

* added swagger code gen check for backward compatibility requirements per review comments

* fixed findbugs error

* updates per swagger regen code and one other update to Idp builder

* fixed expiresAt param type in spec

* deprecated old classes

* refactored InlineHooksIT - deactivate created hooks so it can be cleaned up after test

* Remove deprecated code (#426)

* Remove deprecated code

* fix typo

* fixed PMD violation - unused inports

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/CrudTestSupport.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/FactorsIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/UsersIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* Update integration-tests/src/test/groovy/com/okta/sdk/tests/it/GroupsIT.groovy

Co-authored-by: Brian Demers <bdemers@apache.org>

* minor improvements (#427)

* OKTA-308935: Create Migration Guide for Java Mgmt SDK v2.0.0 (#423)

Co-authored-by: Ivan Ezeigbo <56391095+ivanezeigbo-okta@users.noreply.github.com>
Co-authored-by: Brian Demers <bdemers@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemers bdemers bdemers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvindkrishnakumar-okta @bdemers @codecov-commenter