OKTA-302317: Release Java Mgmt SDK v2.0.0 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…serWithApplicationTest OKTA-279039: Fix flaky ApplicationsIT associateUserWithApplication test
…onsTest OKTA-279039: Fix flaky GroupsIT groupUserOperationsTest test
* openapi csr rename update
* revert csr model rename
* open api spec update
arvindkrishnakumar-okta
requested review from
robertjd,
bretterer,
laura-rodriguez,
bryanapellanes-okta and
shuowu-okta
Addressed. |
shuowu
approved these changes
Jul 6, 2020
bdemers
reviewed
Jul 6, 2020
integration-tests/src/test/groovy/com/okta/sdk/tests/it/CrudTestSupport.groovy
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Jul 6, 2020
integration-tests/src/test/groovy/com/okta/sdk/tests/it/FactorsIT.groovy
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Jul 6, 2020
integration-tests/src/test/groovy/com/okta/sdk/tests/it/GroupsIT.groovy
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Jul 6, 2020
integration-tests/src/test/groovy/com/okta/sdk/tests/it/UsersIT.groovy
Outdated
Show resolved
Hide resolved
bdemers
suggested changes
Jul 6, 2020
There was a problem hiding this comment.
Looks good to me, but we need a few things first:
- fix the changed license headers (see suggestions)
- a completed migration guide (underway on another PR)
- remove remaining deprecated code(I pushed a quick PR Remove deprecated code #426)
* Remove deprecated code * fix typo
…stSupport.groovy Co-authored-by: Brian Demers <bdemers@apache.org>
…sIT.groovy Co-authored-by: Brian Demers <bdemers@apache.org>
…T.groovy Co-authored-by: Brian Demers <bdemers@apache.org>
…IT.groovy Co-authored-by: Brian Demers <bdemers@apache.org>
done
:)
merged it, looks good |
bdemers
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
OKTA-302317
Description
Release Java Mgmt SDK
v2.0.0with Open API v2.0.0 upgrades.ℹ️ Commits beginning 07/01 are the ones that need to be reviewed as part of this PR. Changes shown in this PR prior to 07/01 commit were already reviewed by individual PRs that were merged to this development branch.
Category