OKTA-279039: Fix flaky GroupsIT groupUserOperationsTest test #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindkrishnakumar-okta
changed the title
Codecov Report
@@ Coverage Diff @@
## dev_openapi_v2.0.0_major_rel #386 +/- ##
===============================================================
Coverage 71.05% 71.05%
Complexity 1129 1129
===============================================================
Files 120 120
Lines 3624 3624
Branches 566 566
===============================================================
Hits 2575 2575
Misses 862 862
Partials 187 187 Continue to review full report at Codecov.
|
arvindkrishnakumar-okta
requested review from
bdemers,
vijetmahabaleshwar-okta and
ivanezeigbo-okta
| @@ -153,10 +153,11 @@ class GroupsIT implements CrudTestSupport { | |||
|
|
|||
| // 2. Add user to the group and validate user present in group | |||
| user.addToGroup(group.getId()) | |||
| assertUserInGroup(user, group) | |||
| // try upto 5 times with a delay of 2000ms after each failed attempt | |||
There was a problem hiding this comment.
Ran Travis build couple of times and verified it works.
There was a problem hiding this comment.
@arvindkrishnakumar-okta That's great. I'm running some loops to try local runs. How many times did you happen to run it on Travis?
There was a problem hiding this comment.
Approx 5 - 7 times and tests passed everytime.
ivanezeigbo-okta
approved these changes
May 31, 2020
arvindkrishnakumar-okta
deleted the
fix_flaky_groupsIT_groupUserOperationsTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OKTA-279039
Will apply this to master branch as well.