Updated GroupsIT to fix IT flakiness #381
Conversation
This patch should fix the reported flakiness in IT _com.okta.sdk.tests.it.GroupsIT#groupUserOperationsTest_ (Ref. OKTA-279039).
| @@ -153,10 +153,10 @@ class GroupsIT implements CrudTestSupport { | |||
|
|
|||
| // 2. Add user to the group and validate user present in group | |||
| user.addToGroup(group.getId()) | |||
| assertUserInGroup(user, group) | |||
| assertUserInGroup(user, group, 5, 2000) | |||
There was a problem hiding this comment.
added additional arguments (experimental) for API retry times (value 5) & retry delay in ms (value 2000).
@ivanezeigbo-okta @vijetmahabaleshwar-okta We should try to run the IT suite with this update and check if this fixes the reported test flakiness with com.okta.sdk.tests.it.GroupsIT#groupUserOperationsTest.
There was a problem hiding this comment.
@arvindkrishnakumar-okta awesome, would try running this. We can add delays to specific functions. This is good!
arvindkrishnakumar-okta
requested review from
vijetmahabaleshwar-okta and
ivanezeigbo-okta
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
=========================================
Coverage 70.91% 70.91%
Complexity 1127 1127
=========================================
Files 120 120
Lines 3624 3624
Branches 566 566
=========================================
Hits 2570 2570
Misses 868 868
Partials 186 186 Continue to review full report at Codecov.
|
|
Will address the same change in #386. Will close this PR therefore. |
This patch should fix the reported flakiness in IT com.okta.sdk.tests.it.GroupsIT#groupUserOperationsTest (Ref. OKTA-279039).