doc: correct values/references for buffer.kMaxLength #60305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
cjihrig
approved these changes
Oct 18, 2025
nithamitabh
reviewed
Oct 18, 2025
nithamitabh
left a comment
nithamitabh
left a comment
There was a problem hiding this comment.
Items in changes list are not in order nodejs-yaml
lpinca
approved these changes
Oct 18, 2025
Renegade334
force-pushed
the
doc-buffer-v8-constant
branch
from
1f559ec to
26500c7
Compare
Contributor
Author
|
Rebased for #60304. |
cjihrig
approved these changes
Oct 31, 2025
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9f01ff2 |
aduh95
pushed a commit
that referenced
this pull request
Nov 10, 2025
PR-URL: #60305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 11, 2025
PR-URL: #60305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last update only partially reflected v8/v8@44b2995. The relevant property in the V8 API also changed, and the value was changed from kSmiMaxValue to INT_MAX on 32-bit architectures.