tools: fix linter for semver-major release proposals #60481
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
cjihrig
approved these changes
Oct 29, 2025
aduh95
added
the
author ready
richardlau
approved these changes
Oct 29, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60481 ✔ Done loading data for nodejs/node/pull/60481 ----------------------------------- PR info ------------------------------------ Title tools: fix linter for semver-major release proposals (#60481) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:lint-semver-major -> nodejs:main Labels tools, author ready Commits 2 - tools: fix linter for semver-major release proposals - fixup! tools: fix linter for semver-major release proposals Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60481 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60481 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 29 Oct 2025 14:09:30 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60481#pullrequestreview-3393769053 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/60481#pullrequestreview-3394515531 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18975121161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see in #59896, the linter fails because it can't find in the proposal the commits listed in the CHANGELOG. That's not surprising since the semver-major proposal only contains the release commit – something I forgot to take into account when working on #57892.