-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
benchmark: add per-suite setup option #60574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
0cefcf7 to
3fc7e8a
Compare
|
[Off-Topic] Weird that node-pr-labeler didn't include |
3fc7e8a to
e432cde
Compare
This allows us to set up fixtures for the benchmark suite only once, which can save quite a bit of time when running benchmarks that require tens of thousands of fixture files or more (e.g. the module benchmarks).
e432cde to
34abdcb
Compare
|
It looks like GitHub considered a cancelled action for testing shared libraries as failure, and it's unclear how to restart it. I guess it is safe to ignore, anyway. |
|
Landed in 622c372 |
This allows us to set up fixtures for the benchmark suite only once, which can save quite a bit of time when running benchmarks that require tens of thousands of fixture files or more (e.g. the module benchmarks). PR-URL: #60574 Fixes: #58488 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

This allows us to set up fixtures for the benchmark suite only once, which can save quite a bit of time when running benchmarks that require tens of thousands of fixture files or more (e.g. the module benchmarks).
Fixes: #58488