util: add fast path for Latin1 decoding

[mertcanaltin]

I added a fast path for Latin1 (windows-1252) decoding to improve performance. This change avoids using the slower ICU-based decoding for Latin1 and instead utilizes a direct approach, similar to the fast path implemented for UTF-8.
nodejs/performance#178

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg
• @nodejs/v8-update

[codecov]

Codecov Report

Attention: Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (bbdfeeb) to head (77bc5ee).
Report is 222 commits behind head on main.

Files with missing lines	Patch %	Lines
src/encoding_binding.cc	10.34%	26 Missing ⚠️
lib/internal/encoding.js	55.55%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55275      +/-   ##
==========================================
- Coverage   88.41%   88.39%   -0.03%     
==========================================
  Files         652      652              
  Lines      186612   186799     +187     
  Branches    36062    36120      +58     
==========================================
+ Hits       165001   165117     +116     
- Misses      14885    14944      +59     
- Partials     6726     6738      +12     

Files with missing lines	Coverage Δ
src/encoding_binding.h	100.00% <ø> (ø)
lib/internal/encoding.js	98.87% <55.55%> (-0.64%)	⬇️
src/encoding_binding.cc	71.42% <10.34%> (-12.82%)	⬇️

... and 48 files with indirect coverage changes

[anonrig]

Can you update benchmarks as well?

[mertcanaltin]

Can you update benchmarks as well?

I wonder if this is the right place.
benchmark/util/text-decoder.js

[lemire]

Would be nice to have before/after benchmark numbers, even if it is just on someone's laptop.

[mertcanaltin]

I think I shared my comparison with you in a wrong way, I'm sorry, there is a lot of data, I wonder if you have a suggestion on this

[lemire]

@mertcanaltin

Try something like this...

$ npm install -g node-benchmark-compare

$ node benchmark/compare.js --new mynewnode --old myoldnode --runs 1000 --filter text-decoder  util >  text-decoder.csv

$ node-benchmark-compare text-decoder.csv 

Replace mynewnode and myoldnode by the actual node binaries.

[anonrig]

You need to update the benchmark file to actually test windows-1252 rather than latin1. It appears that the benchmark passes latin1 (Which is wrong)

[mertcanaltin]

so here we are, we've started a benchmark, @RafaelGSS thanks
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1644/

[github-actions]

Failed to start CI

   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/11675818532

[lemire]

@anonrig @mertcanaltin Where is this issue at? It has been opened for a long time.

[anonrig]

Approving to run the CI

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63432/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6269/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6269/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6269/