test: move localizationd data from test-icu-env to external file
#55618
+503
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55618 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187752 187757 +5
Branches 36127 36121 -6
=======================================
+ Hits 165977 165985 +8
+ Misses 15013 14999 -14
- Partials 6762 6773 +11 |
|
I like the idea. I think there should be separate versions of the fixture per ICU version and then we could remove the current restriction that the test only runs with the bundled/builtin ICU. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
the
commit-queue-squash
richardlau
approved these changes
Nov 1, 2024
aduh95
reviewed
Nov 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Nov 5, 2024
jasnell
approved these changes
Nov 6, 2024
LiviaMedeiros
force-pushed
the
test-icu-env-json
branch
from
7605bf2
to
10ea9f0
Compare
github-actions
bot
removed
the
request-ci
|
Not sure why we have this directory ignored by linter Line 56 in 6af5c4e |
|
It was added to the ignore list in 6add5b3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #50515 (comment)
Related to: #55551 (the data in current PR is generated using version
75.1)