net: add net.BlockList.isBlockList(value) #56078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Nov 29, 2024
anonrig
added
the
semver-minor
theanarkh
approved these changes
Nov 29, 2024
lpinca
approved these changes
Nov 29, 2024
jasnell
force-pushed
the
add-isblocklist
branch
from
b65f654 to
01f2756
Compare
jasnell
added
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
atlowChemi
reviewed
Dec 2, 2024
| /** | ||
| * Returns true if the value is a BlockList | ||
| * @param {any} value | ||
| * @returns {boolean} |
Member
There was a problem hiding this comment.
I think we could use asserts here
Suggested change
| * @returns {boolean} | |
| * @returns {asserts value is BlockList} |
Member
Author
There was a problem hiding this comment.
I'm not quite sure what this would accomplish. The method does not assert at all, it just returns true or false and should not throw any errors.
atlowChemi
approved these changes
Dec 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
add-isblocklist
branch
from
01f2756 to
d59f41f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Member
Author
|
Landed in c7de0ec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.