Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing documentation for PerformanceObserver.prototype.takeRecords() #55786

Merged
merged 1 commit into from
Nov 25, 2024
Merged

doc: add missing documentation for PerformanceObserver.prototype.takeRecords() #55786

merged 1 commit into from
Nov 25, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 8, 2024 •
edited
Loading

The PR add missing documentation for PerformanceObserver.prototype.takeRecords(), which landed in v16.0.0 with PerformanceObserver.supportedEntryTypes

confirmed by the release v16.0.0 and impl PR #37136

see also mdn documentation and specification

Fixes: #55779

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Nov 8, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 8, 2024 16:34
@avivkeller
Copy link
Member

Hi! Can you please amend your commit to follow the guidelines? It's a bit too long.

@skyclouds2001
Copy link
Contributor Author

Hi! Can you please amend your commit to follow the guidelines? It's a bit too long.

Sure!

@skyclouds2001 skyclouds2001 force-pushed the fix-55779-PerformanceObserver-takeRecords branch from d379b7a to 04c1d1f Compare November 8, 2024 22:53
@skyclouds2001
Copy link
Contributor Author

Done!

aduh95
aduh95 reviewed Nov 14, 2024
View reviewed changes
doc/api/perf_hooks.md Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 force-pushed the fix-55779-PerformanceObserver-takeRecords branch from 04c1d1f to 0624b37 Compare November 14, 2024 03:07
@skyclouds2001 skyclouds2001 force-pushed the fix-55779-PerformanceObserver-takeRecords branch from 0624b37 to ab83e2c Compare November 14, 2024 03:22
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit b17a1fb into nodejs:main Nov 25, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b17a1fb

@skyclouds2001 skyclouds2001 deleted the fix-55779-PerformanceObserver-takeRecords branch November 25, 2024 10:47
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@skyclouds2001 @Ceres6
doc: add doc for PerformanceObserver.takeRecords()
5c952f3 
PR-URL: nodejs#55786
Fixes: nodejs#55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@skyclouds2001 @aduh95
doc: add doc for PerformanceObserver.takeRecords()
a3f7db6 
PR-URL: #55786
Fixes: #55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aduh95 aduh95 mentioned this pull request Nov 28, 2024
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@skyclouds2001 @aduh95
doc: add doc for PerformanceObserver.takeRecords()
582bed5 
PR-URL: #55786
Fixes: #55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@skyclouds2001 @aduh95
doc: add doc for PerformanceObserver.takeRecords()
6761356 
PR-URL: #55786
Fixes: #55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@skyclouds2001 @aduh95
doc: add doc for PerformanceObserver.takeRecords()
b5181ed 
PR-URL: #55786
Fixes: #55779
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@jazelly jazelly jazelly approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing documentaion for PerformanceObserver.prototype.takeRecords() of perf_hooks module
6 participants
@skyclouds2001 @avivkeller @nodejs-github-bot @jasnell @aduh95 @jazelly