v15.11.0 release proposal #37569
Merged
v15.11.0 release proposal #37569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpdir.refresh() cannot be called multiple times reliably on Raspberry Pi in CI because NFS might optimistically report a path as removed before it actually is. At least, that's what I think is going on. Anyway, tmpdir.refresh() is generally designed to be called once, so let's just call it once. PR-URL: #37371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37297 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #37187 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It seems that **Default:** was unofficially decided on as the way to specify default values. This commit updates the API documentation to use this format more consistently. PR-URL: #37387 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit updates fsPromises.watch() to use the createDeferredPromise() utility. PR-URL: #37386 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
* Use a copy of plaintext to prevent tampering of the original * Since subtle.decrypt returns a Promise containing an ArrayBuffer and ArrayBuffers cannot be modified directly, create a Buffer from it right away so that the modification in the next line works as intended Fixes: #35586 PR-URL: #37380 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #37394 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add support for loading modules using percent-encoded URLs. PR-URL: #37392 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
The finalizer normally never gets called while a reference is strong. However, during environment shutdown all finalizers must get called. In order to unify the deferring behavior with that of a regular finalization, we must force the reference to be weak when we call its finalizer during environment shutdown. Fixes: #37236 Co-authored-by: Chengzhong Wu <legendecas@gmail.com> PR-URL: #37303 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #37396 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This patch adds the SnapshotableObject interface. Native objects supporting serialization can inherit from it, implementing PrepareForSerialization(), Serialize() and Deserialize() to control how the native states should be serialized and deserialized. See doc: https://docs.google.com/document/d/15bu038I36oILq5t4Qju1sS2nKudVB6NSGWz00oD48Q8/edit PR-URL: #36943 Fixes: #35930 Refs: #35711 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #37364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
We're about to turn on a requirement for dangling commas. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Where possible used HEAD in links Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37421 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The following warnings are disabled: - C4065 in node_revert.h: there are no security reversions on the master branch. - C4003 in base64-inl.h: a macro is used four times, only once without parameters. PR-URL: #37334 Reviewed-By: James M Snell <jasnell@gmail.com>
A comment was written before the last line, hiding a check. PR-URL: #37334 Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #26401 Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com> PR-URL: #37372 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
I presume "The can..." should be "They can...". PR-URL: #37417 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
From the code `nodejs@8` and up should behave the same:
github.com/nodejs/node/blame/v8.17.0/lib/internal/child_process.js#L290
And a short test snippet:
```js
const { spawn } = require('child_process')
const subProcess = spawn('non-exist-command')
subProcess.on('error', (error) =>
console.warn('mute Unhandled "error" event:', error))
console.log('- pid:', subProcess.pid)
process.nextTick(() => console.log('- after error emit'))
console.log('== end of test ==')
```
Note: the sync spawn result `pid` currently do not follow this pattern.
Co-authored-by: Rich Trott <rtrott@gmail.com>
PR-URL: #37014
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Note: this only add checks for async spawn, as the sync spawn do not return a `subProcess`. PR-URL: #37014 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
/cc @nodejs/releasers |
|
For some reason, the coverage workflow doesn't work with this changeset: |
It seems this workflow is broken for all PRs recently: https://github.com/nodejs/node/actions/workflows/coverage-linux.yml |
It looks like the workflows have switched to using gcc 9 (probably when GitHub switched the Linux runners to default to Ubuntu 20.04) but that doesn't explain why the non-coverage Linux Action workflows are not similarly failing. |
|
It seems the error comes from the Inspector code, and the non-coverage action doesn't include it I believe. For reference the error is reported here: node/tools/inspector_protocol/encoding/encoding.cc Lines 836 to 837 in 5aaa7fe |
|
PR to fix the warning: #37573 |
|
Any objection to proceeding with the release even with this error? |
danielleadams
approved these changes
Mar 2, 2021
This comment has been minimized.
This comment has been minimized.
BethGriggs
approved these changes
Mar 2, 2021
codebytere
approved these changes
Mar 2, 2021
ruyadorno
approved these changes
Mar 2, 2021
|
I'll have to do the release tomorrow. macOS notarization failed twice with |
targos
force-pushed
the
v15.11.0-proposal
branch
from
d59fe31
to
d816b24
Compare
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 3, 2021
targos
removed
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-03-02, Version 15.11.0 (Current), @targos
Notable Changes
a3e3156b52] - (SEMVER-MINOR) crypto: make FIPS related options always awailable (Vít Ondruch) #363419ba5c0f9ba] - (SEMVER-MINOR) errors: remove experimental from --enable-source-maps (Benjamin Coe) #37362Commits
d039e6fa80] - assert: refactor to avoid unsafe array iteration (Antoine du Hamel) #37344d2e5529e08] - bootstrap: include v8 module into the builtin snapshot (Joyee Cheung) #3694359861bac0e] - bootstrap: include fs module into the builtin snapshot (Joyee Cheung) #36943458a4108b7] - buffer: make Blob's constructor more spec-compliant (Michaël Zasso) #373610d564ce214] - buffer: make Blob's slice method more spec-compliant (Michaël Zasso) #37361ddae112133] - child_process: fix spawn and fork abort behavior (Nitzan Uziely) #37325b1e188de8d] - crypto: refactor hasAnyNotIn to avoid unsafe array iteration (Antoine du Hamel) #37433291d9e9936] - crypto: check ed/x webcrypto key import algorithm names (Filip Skokan) #37305a3e3156b52] - (SEMVER-MINOR) crypto: make FIPS related options always awailable (Vít Ondruch) #36341b634469c38] - crypto: refactor to avoid unsafe array iteration (Antoine du Hamel) #3736401773ab614] - crypto: use BoringSSL compatible errors (Shelley Vohr) #37297f3d67000a0] - deps: upgrade npm to 7.6.0 (Ruy Adorno) #37559e1045f1004] - deps: upgrade npm to 7.5.6 (Ruy Adorno) #3749680d3c118f4] - deps: V8: cherry-pick 373f4ae739ee (Richard Lau) #375051408de7e24] - deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream (Antoine du Hamel) #37471725d48ae77] - doc: remove experimental from --enable-source-maps (Colin Ihrig) #375405d939b7a49] - doc: fix typo in doc/api/packages.md (marsonya) #37536cbfc6b1692] - doc: document how to register external bindings for snapshot (Joyee Cheung) #37463dd7a04dc9f] - doc: fix typo "director" instead of "directory" (humanwebpl) #37523ba81e7cb5e] - doc: revise LTS text in collaborator guide (Rich Trott) #375277529a97a5c] - doc: revise CI text in collaborator guide (Rich Trott) #375261285b907ce] - doc: revise objections section of collaborator guide (Rich Trott) #37525bc86208a0a] - doc: revise premature disclosure text in collaborator guide (Rich Trott) #3752446af56752e] - doc: change links to use HEAD in top level docs (Michael Dawson) #374943b737e63ce] - doc: apply sentence case to headers in doc/guides (marsonya) #37506fb5e5bed21] - doc: fix typo in webcrypto.md (marsonya) #375073b7cb75554] - doc: document the NO_COLOR and FORCE_COLOR env vars (James M Snell) #374770fac27d546] - doc: add url.resolve replacement example (Antoine du Hamel) #375012228f44b25] - doc: apply sentence case to guides headers (marsonya) #37497617819e4fb] - doc: update CI requirements for landing pull requests (Antoine du Hamel) #373084a40759b33] - doc: recommend queueMicrotask over process.nextTick (James M Snell) #37484834f63793a] - doc: apply sentence case to headers in doc/guides (marsonya) #374787ac0820da0] - doc: fix typo in doc/api/http2/md (marsonya) #374794ad7a78448] - doc: alphabetize vm Module class properties (Rich Trott) #37451a193d7ca87] - doc: alphabetize crypto Cipher class entries (Rich Trott) #3745054b6f1bcf9] - doc: use HEAD for links in api docs (Michael Dawson) #37437549d24b8ad] - doc: fix alignment of parameters (Michael Dawson) #37422f3559a922b] - doc: fix typo in doc/api/esm.md (marsonya) #37400c3d236d405] - doc: fix "referred to" in fs docs (Tobias Nießen) #373889ac8c74539] - doc: document x509 error codes (Dan Čermák) #370969a454afcd6] - doc: fix typo in esm.md (Jay Tailor) #37417b3bf3d9824] - doc: use HEAD in links where possible (Michael Dawson) #374216675342cd9] - doc: clarify that async_hook callbacks cannot be async (James M Snell) #373844b54c10500] - doc: use **Default:** more consistently (Colin Ihrig) #37387f20ce47dbb] - doc,child_process:pidcan beundefinedwhenENOENT(dr-js) #370146205e29cb9] - doc,lib: prepare for stricter multi-line array linting (Rich Trott) #370889ba5c0f9ba] - (SEMVER-MINOR) errors: remove experimental from --enable-source-maps (Benjamin Coe) #37362c0cdb83433] - fs: fix writeFile signal does not close file (Nitzan Uziely) #37402e8b1e2c0a3] - fs: fix pre-aborted writeFile AbortSignal file leak (Nitzan Uziely) #373936b42e65983] - fs: fixup negative length in fs.truncate (James M Snell) #37483d141fce634] - fs: use createDeferredPromise() in promises.watch() (Colin Ihrig) #37386bb81accb16] - lib: use <array>.push and <array>.unshift instead of <array>.concat (Antoine du Hamel) #37239dc3c299862] - lib: remove outdated todo comment (Antoine du Hamel) #37396856d20b772] - lib: add URI handling functions to primordials (Antoine du Hamel) #37394a1ed78cb3b] - module: improve support of data: URLs (Antoine du Hamel) #3739227816eac61] - node-api: force env shutdown deferring behavior (Gabriel Schulhof) #37303f1381f7a7a] - src: fix alloc-dealloc-mismatch in node_snapshotable.h (Darshan Sen) #374435ea2ed611f] - src: fix ETW_WRITE_EMPTY_EVENT macro (Michaël Zasso) #3733496bcd52d3e] - src: disable unfixable MSVC warnings (Michaël Zasso) #37334c75f5f372d] - src: avoid implicit type conversions (take 2) (Michaël Zasso) #37334e400f8c9c8] - src: support serialization of binding data (Joyee Cheung) #36943daad7bbd34] - src: adjust THP sysfs config token retrieval and file closure (James Addison) #371874cc76457d9] - stream: move duplicated code to an internal module (Rich Trott) #375083d3df0c005] - stream: add AbortSignal support to finished (Nitzan Uziely) #37354429dffd32e] - stream: add AbortSignal to promisified pipeline (Nitzan Uziely) #373599696cf7142] - test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls (Rich Trott) #37533453113938d] - test: make status file names consistent (Rich Trott) #3753200b3446a8e] - test: account for pending deprecations in esm test (Rich Trott) #37542f2aa305348] - test: fix incorrect timers-promisified case (ttzztztz) #37425ce7fbbf94c] - test: fix typo in test_node_crypto.cc (Ikko Ashimine) #37469ba319f0c60] - test: remove FLAKY for test-http2-compat-client-upload-reject (Rich Trott) #37462dfa0440341] - test: validate no debug info for http2 (Michael Dawson) #37447b38404ee17] - test: remove FLAKY designation for test-http2-client-upload-reject (Rich Trott) #37461b569105183] - test: clarify usage of tmpdir.refresh() (Darshan Sen) #373834f41900687] - test: update upload.zip to be uncorrupted (Greg Ziskind) #37294d5c311ed15] - test: fix flaky test-worker-prof (Rich Trott) #37372df538ebc8e] - test: fix flaky test-webcrypto-encrypt-decrypt-aes (Darshan Sen) #3738019d6eb929c] - test: fix flaky test-fs-promises-file-handle-read (Rich Trott) #37371c554aa149c] - test,child_process: add check forsubProcess.pid(dr-js) #370145c27fd73b0] - tools: run doctool tests on GitHub Actions CI (Antoine du Hamel) #3739849013fcee1] - tools: make comma-dangle ESLint rule more stringent … (Rich Trott) #3708831f4600b7a] - worker: fix interaction of terminate() with messaging port (Anna Henningsen) #37319d93137b2a9] - workers: fix spawning from preload scripts (James M Snell) #37481