doc: document the NO_COLOR and FORCE_COLOR env vars#37477
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
doc: document the NO_COLOR and FORCE_COLOR env vars#37477jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
aduh95
approved these changes
Feb 22, 2021
Trott
reviewed
Feb 22, 2021
Trott
reviewed
Feb 22, 2021
Trott
reviewed
Feb 22, 2021
Member
|
These entries need to be duplicated into |
Trott
reviewed
Feb 23, 2021
Trott
previously requested changes
Feb 23, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Looks good to me, but leaving a "Request changes" until the entries are in doc/node.1 as well. Feel free to dismiss this review once that's happened.
jasnell
force-pushed
the
no_color_force-color
branch
from
e9a759f to
1d4d8b2
Compare
jasnell
added
author ready
juanarbol
approved these changes
Feb 23, 2021
BridgeAR
removed
the
author ready
Trott
approved these changes
Feb 24, 2021
jasnell
force-pushed
the
no_color_force-color
branch
from
1d4d8b2 to
ff754fe
Compare
Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: nodejs#37404
jasnell
force-pushed
the
no_color_force-color
branch
from
ff754fe to
95b0fe7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
Member
Author
|
Landed in fc6d8f4 |
Alhadis
reviewed
Mar 5, 2021
Comment on lines
+535
to
+536
| .Ar 1 | ||
| , |
Contributor
There was a problem hiding this comment.
Most mdoc(7) macros allow authors to include trailing punctuation as a separate (final) argument:
.Ar 1 ,See the "Delimiters" section of mdoc(7) for more info on this feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #37404