crypto: check ed/x webcrypto key import algorithm names #37305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
crypto
jasnell
approved these changes
Feb 23, 2021
This comment has been minimized.
This comment has been minimized.
jasnell
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Collaborator
Collaborator
PR-URL: nodejs#37305 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
more-edx-import-fixes
branch
from
8596512 to
8ddee73
Compare
Contributor
|
Landed in 8ddee73 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
PR-URL: #37305 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple things in the
webcryptoexperimental moduleNODE-ED*ECDHnodeEdKeyImportParams.publicparameter is only used with therawformat.Previously you couldn't import these using the
node.keyObjectformat at all despite the support matrix saying so.