doc: change links to use HEAD in top level docs#37494
Merged
Trott merged 1 commit intonodejs:masterfrom Feb 27, 2021
Merged
Conversation
nodejs-github-bot
added
build
aduh95
approved these changes
Feb 23, 2021
jasnell
approved these changes
Feb 23, 2021
marsonya
approved these changes
Feb 24, 2021
richardlau
reviewed
Feb 24, 2021
LICENSE
Outdated
Comment on lines
422
to
423
| # Dictionary: https://github.com/veer66/lao-dictionary/blob/HEAD/Lao-Dictionary.txt | ||
| # License: https://github.com/veer66/lao-dictionary/blob/HEAD/Lao-Dictionary-LICENSE.txt |
Member
There was a problem hiding this comment.
These two come from upstream ICU’s LICENSE (
Lines 288 to 289 in 80098e6
tools/license-builder.sh is run to regenerate the LICENSE.
Member
Author
There was a problem hiding this comment.
Thanks good catch. I'm not sure how I included those as I was not planning any changes in files within dependencies.
Trott
approved these changes
Feb 24, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with LICENSE file changes removed.
RaisinTen
approved these changes
Feb 27, 2021
Change the top level docs to use HEAD in links Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#37494 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
|
Landed in 7a4c2c8 |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
Change the top level docs to use HEAD in links Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37494 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Change the top level docs to use HEAD in links Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37494 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the top level docs to use HEAD in links
Signed-off-by: Michael Dawson mdawson@devrus.com