Allow passing defines such as -- -DFOO=bar

[ilatypov]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

My small change in node-pre-gyp hit a wall because node-gyp configure .. -- -DFOO=bar results in creating an msbuild option /t:-DFOO=bar, thank you very much.

mapbox/node-pre-gyp#416

[ilatypov]

Sorry I do not know how to run tests. I see some added in the change that exposed my issue.

#1164

[refack]

Hello @ilatypov and thank you for the contribution.
Could you write a test for this change? An example can be:

node-gyp/test/test-addon.js

Lines 34 to 48 in aebdd7a

	test('build simple addon', function (t) {
	t.plan(3)
	// Set the loglevel otherwise the output disappears when run via 'npm test'
	var cmd = [nodeGyp, 'rebuild', '-C', addonPath, '--loglevel=verbose']
	var proc = execFile(process.execPath, cmd, function (err, stdout, stderr) {
	var logLines = stderr.toString().trim().split(/\r?\n/)
	var lastLine = logLines[logLines.length-1]
	t.strictEqual(err, null)
	t.strictEqual(lastLine, 'gyp info ok', 'should end in ok')
	t.strictEqual(runHello().trim(), 'world')
	})
	proc.stdout.setEncoding('utf-8')
	proc.stderr.setEncoding('utf-8')
	})

(BTW: you run the test suite with a simple npm install; npm test)

[kewde]

Hmm, this is an issue that does not only affect the the configure options but also overloading of properties.

/p:FOO=bar

becomes

/t:/p:FOO=bar

This fix wouldn't apply in all cases :/

[rvagg]

@ilatypov would still like to pursue this? if so, please rebase to the current master and let's see if we can figure out a test for it.

[cclauss]

Too many conflicts.