Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-gyp fails to find VS 2017 if "USB Device Connectivity" component is installed in VS 15.7 #1466

Closed
tydunkel opened this issue Jun 12, 2018 · 2 comments
Closed

node-gyp fails to find VS 2017 if "USB Device Connectivity" component is installed in VS 15.7 #1466

tydunkel opened this issue Jun 12, 2018 · 2 comments
Assignees
@refack
Labels
confirmed-bug Windows

Comments

@tydunkel
Copy link

  • Node Version: node v8.4 npm 6.1.0 node-gyp 3.6.2
  • Platform: Win10
  • Full VS 15.7 installation

node-gyp configure will fail to find VS 2017 if a full installation of 15.7 is installed.

Visual Studio 15.7 added a new optional component named "USB Device Connectivity". The id of the component is Microsoft.VisualStudio.Component.Windows10SDK.IpOverUsb. This will cause the UInt32.Parse call in the line of code linked below to throw, resulting in node-gyp using default settings.

node-gyp/lib/Find-VS2017.cs

Line 235 in b5b52f7

Win10SDKVer = Math.Max(Win10SDKVer, UInt32.Parse(parts[0]));

Maybe consider a try/catch for the parse, or checking with regex that parts[0] is actually a valid number.
@bzoz
Copy link
Contributor

bzoz commented Jun 13, 2018

/cc @refack

@refack refack self-assigned this Jun 13, 2018
@refack
Copy link
Contributor

refack commented Jun 13, 2018

Looking into this.

@Benleie Benleie mentioned this issue Jul 30, 2018
Closed
@joaocgreis joaocgreis mentioned this issue Aug 1, 2018
Closed
2 tasks
Loghorn added a commit to Loghorn/node-gyp that referenced this issue Aug 2, 2018
@Loghorn
win: improve parsing of SDK version
251d2ca 
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: nodejs#1466
joaocgreis pushed a commit to JaneaSystems/node-gyp that referenced this issue Aug 8, 2018
@Loghorn @joaocgreis
win: improve parsing of SDK version
6a9072f 
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: nodejs#1466
joaocgreis pushed a commit that referenced this issue Aug 8, 2018
@Loghorn @joaocgreis
win: improve parsing of SDK version
340403c 
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: #1466
PR-URL: #1516
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@refack refack

Labels
confirmed-bug Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@refack @bzoz @tydunkel