Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: don't print xcodebuild not found errors #1370

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Jan 21, 2018

As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run.

Refs: #1057
Refs: https://chromium-review.googlesource.com/c/492046/
Refs: #569

As the previous attempts haven't landed, I thought I'd aim for a minimal diff. This seems to remove all node-gyp build warnings during npm install of a native module, and errors from running configure in node core, although for some reason the first line in Node's built-in gyp uses xcrun rather than xcodebuild.

This is caused by me running a "getting started with node" course, and having half the audience stuck because "there was an error in the build".

Checklist

gibfahn added a commit to gibfahn/node-gyp that referenced this pull request Mar 14, 2018
As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be
printing the error every time GYP is run.

PR-URL: nodejs#1370
Refs: nodejs#1057
Refs: https://chromium-review.googlesource.com/c/492046/
Refs: nodejs#569
As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be
printing the error every time GYP is run.

PR-URL: nodejs#1370
Fixes: nodejs#569
Refs: nodejs#1057
Refs: https://chromium-review.googlesource.com/c/492046/
@gibfahn
Copy link
Member Author

gibfahn commented Mar 16, 2018

@gibfahn gibfahn merged commit 3a52936 into nodejs:master Mar 16, 2018
@gibfahn gibfahn deleted the ignore-xcodebuild branch March 16, 2018 10:01
ryzokuken added a commit to ryzokuken/node that referenced this pull request Jul 12, 2018
Muffle gyp from creating xcode-select related warnings, essentially
flooding the console.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>
Refs: nodejs/node-gyp#1370
Refs: nodejs#21520
refack pushed a commit to ryzokuken/node that referenced this pull request Aug 24, 2018
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: nodejs#21999
Original-PR-URL: nodejs/node-gyp#1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ryzokuken added a commit to nodejs/node that referenced this pull request Aug 24, 2018
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #21999
Original-PR-URL: nodejs/node-gyp#1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to nodejs/node that referenced this pull request Aug 27, 2018
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #21999
Original-PR-URL: nodejs/node-gyp#1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to nodejs/node that referenced this pull request Sep 3, 2018
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #21999
Original-PR-URL: nodejs/node-gyp#1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to nodejs/node that referenced this pull request Sep 6, 2018
Muffle xcodebuild warnings by introducing an alternative quieter
alternative to GetStdout, called GetStdoutQuiet, and call it selectively
in particularly noisy xcodebuild commands.

Co-authored-by: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #21999
Original-PR-URL: nodejs/node-gyp#1370
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
duqingnian pushed a commit to duqingnian/gyp that referenced this pull request Apr 26, 2024
Patch Set 1:

Is there anything I can do to get this landed? It'd be really useful to have this fixed in Node, as it massively confuses everyone building a native module (see nodejs/node-gyp#569 for example).

I am happy to PR a minimal diff (see nodejs/node-gyp#1370) if that'd be helpful.

Patch-set: 1
CC: Gerrit User 1249742 <1249742@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
duqingnian pushed a commit to duqingnian/gyp that referenced this pull request Apr 26, 2024
Patch Set 1:

> Patch Set 1:
> 
> Is there anything I can do to get this landed? It'd be really useful to have this fixed in Node, as it massively confuses everyone building a native module (see nodejs/node-gyp#569 for example).
> 
> I am happy to PR a minimal diff (see nodejs/node-gyp#1370) if that'd be helpful.

I think we need the issues Mark identified to be addressed?

Patch-set: 1
Reviewer: Gerrit User 1003232 <1003232@3ce6091f-6c88-37e8-8c75-72f92ae8dfba>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants