Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Header-ify the Install instructions #1225

Closed
wants to merge 1 commit into from

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Jun 6, 2017

Enable linking to the platform specific installation instructions.

The initial heading levels were changed since it was goin h1->h3 for the subheading

Enable linking to the platform specific installation instructions
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I paste links all the time. More headers more # fragment links!


* Option 2: Install [Visual Studio 2015](https://www.visualstudio.com/products/visual-studio-community-vs) (or modify an existing installation) and select *Common Tools for Visual C++* during setup. This also works with the free Community and Express for Desktop editions.

> :bulb: [Windows Vista / 7 only] requires [.NET Framework 4.5.1](http://www.microsoft.com/en-us/download/details.aspx?id=40773)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the 💡 but it's a GitHub only feature.
IMHO you could put *Note*: like was set in node core nodejs/node#13133

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was already there as I only re-indented the lists https://github.com/nodejs/node-gyp/pull/1225/files?w=1
I can change that in this if you want though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for other people to chime in...

@refack
Copy link
Contributor

refack commented Jun 6, 2017

@nschonni thank you for doing this. Good idea 🥇

@refack refack self-assigned this Jun 7, 2017
refack pushed a commit to refack/node-gyp that referenced this pull request Jun 11, 2017
Enable linking to the platform specific installation instructions

PR-URL: nodejs#1225
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack
Copy link
Contributor

refack commented Jun 11, 2017

Landed in 35e1dbb

@refack refack closed this Jun 11, 2017
@nschonni nschonni deleted the patch-1 branch June 11, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants