Skip to content

Conversation

@hanalysis
Copy link
Contributor

PR checklist

Closes #9942

  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • [See below] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • [See below] nf-core modules test <MODULE> --profile conda

Regarding Bioconda - telescope already exists as a bioconda recipe (https://bioconda.github.io/recipes/telescope/README.html) however, several people (myself included) have found that this version no longer runs without some adjustments (see: mlbendall/telescope#44). I've found that telescope works with one minimal update, originally made by the author but never updated in conda (mlbendall/telescope@5d0325c). So I've made a docker image which just makes this minor update so the software can run. This seemed to me to be the most sensible way to proceed, but please let me know if there's something else I should do.

Lastly - telescope only produces output if there's any alignments with transposable element annotations, which there weren't with the test data. This is why my test just checks the log to ensure the run finished. Similarly, this just seemed like a pragmatic approach but do let me know if I should try something else.

Thanks!

@hanalysis hanalysis requested review from a team as code owners February 9, 2026 15:20
@mashehu
Copy link
Contributor

mashehu commented Feb 9, 2026

@nf-core-bot fix linting

hanalysis and others added 3 commits February 9, 2026 15:29
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
label 'process_single'

//conda "${moduleDir}/environment.yml" -- No conda at the moment
container 'docker.io/hanalysis/telescope_1.0.3_clip'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you instead of providing you own docker container build it as a seqera container: https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers

[
"TELESCOPE_ASSIGN",
"telescope",
""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is off with the version capture. double check your sed command please 🙂

@prototaxites
Copy link
Contributor

Regarding Bioconda - telescope already exists as a bioconda recipe (https://bioconda.github.io/recipes/telescope/README.html) however, several people (myself included) have found that this version no longer runs without some adjustments (see: mlbendall/telescope#44). I've found that telescope works with one minimal update, originally made by the author but never updated in conda (mlbendall/telescope@5d0325c). So I've made a docker image which just makes this minor update so the software can run. This seemed to me to be the most sensible way to proceed, but please let me know if there's something else I should do.

If there's no chance the author can be convinced to tag a new release, it might be worth trying to update the bioconda recipe to use this commit - bioconda recipes can be set up to pull on a particular commit of a repo instead of a particular tagged release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: telescope/assign

4 participants