-
Notifications
You must be signed in to change notification settings - Fork 964
Telescope #9948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Telescope #9948
Conversation
|
@nf-core-bot fix linting |
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
| label 'process_single' | ||
|
|
||
| //conda "${moduleDir}/environment.yml" -- No conda at the moment | ||
| container 'docker.io/hanalysis/telescope_1.0.3_clip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you instead of providing you own docker container build it as a seqera container: https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers
| [ | ||
| "TELESCOPE_ASSIGN", | ||
| "telescope", | ||
| "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something is off with the version capture. double check your sed command please 🙂
If there's no chance the author can be convinced to tag a new release, it might be worth trying to update the bioconda recipe to use this commit - bioconda recipes can be set up to pull on a particular commit of a repo instead of a particular tagged release. |
PR checklist
Closes #9942
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condaRegarding Bioconda - telescope already exists as a bioconda recipe (https://bioconda.github.io/recipes/telescope/README.html) however, several people (myself included) have found that this version no longer runs without some adjustments (see: mlbendall/telescope#44). I've found that telescope works with one minimal update, originally made by the author but never updated in conda (mlbendall/telescope@5d0325c). So I've made a docker image which just makes this minor update so the software can run. This seemed to me to be the most sensible way to proceed, but please let me know if there's something else I should do.
Lastly - telescope only produces output if there's any alignments with transposable element annotations, which there weren't with the test data. This is why my test just checks the log to ensure the run finished. Similarly, this just seemed like a pragmatic approach but do let me know if I should try something else.
Thanks!