-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename instances of "monkeypox" to "mpox" #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending one small change which I'll address.
If people request from Otherwise, for those requesting directly from AWS not via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I would consider setting a HTTP redirect from https://data.nextstrain.org/files/workflows/monkeypox
to https://data.nextstrain.org/files/workflows/mpox
if this is possible
This commit goes through the repo and basically does a find-and-replace of "monkeypox" to "mpox, except for a handful of locations like the #monkeypox-updates Slack notification. This shouldn't change appearance of build outputs except for: - Updating to "Built by nextstrain/mpox" - Updating page titles to be more descriptive of what each page is showing in terms of lineages / clades - A bug fix to the page description to link to proper build URLs (currently these go to 404) This has the side effect that intermediate files will begin to propagate to https://data.nextstrain.org/files/workflows/mpox/sequences.fasta.xz, etc... rather than `/files/workflows/monkeypox`. This may affect users who've been relying on the current URLs. Nothing should break for these users as the old files will continue to exist but they will no longer receive updated data. I think this is an okay trade-off in terms of downstream impacts.
Addressing this separately in #221 |
2726980
to
e741132
Compare
subrepo: subdir: "ingest/vendored" merged: "a0faef5" upstream: origin: "https://github.com/nextstrain/ingest" branch: "main" commit: "a0faef5" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
These are all the repos that Github could find using These are the repos that use aws s3 paths that can't be redirected (10 mostly ours): https://github.com/search?q=s3%3A%2F%2Fnextstrain-data%2Ffiles%2Fworkflows%2Fmonkeypox&type=code |
Yes, definitely possible. Not sure if we need to do it on the Cloudfront side but it's possible to configure S3 website redirections. Also looks like it's possible to redirect requests for an S3 object Edit: The S3 object redirect is via |
The fetch and ingest workflow completed successfully. However, the artifacts ended up at s3://nextstrain-datafiles/workflows/mpox/branch/rename-to-mpox/. However, it looks good besides this. I'm assuming the best course of action is to merge this PR when it passes review and then to run fetch and ingest again from |
Thanks @victorlin for the fix with commit b14d6fd. I'm going to go ahead and merge this now. |
Fetch and ingest is running from |
We discussed redirection rules for monkeypox during today's dev chat and I added @tsibley 's suggested redirection rules to the So now access through data.nextstrain.org should redirect to mpox
Redirection for the |
Perfect! Thank you @joverlee521. I can confirm that I deleted the I believe the next step here is to confirm that a phylogenetics rebuild works as expected. I'll kick this off now. |
And actually... this testing already happened with the automatic updates. Earlier today actions including https://github.com/nextstrain/mpox/actions/runs/6735424381 ran and produced updated Auspice JSONs like |
This commit goes through the repo and basically does a find-and-replace of "monkeypox" to "mpox, except for a handful of locations like the #monkeypox-updates Slack notification.
This shouldn't change appearance of build outputs except for:
This has the side effect that intermediate files will begin to propagate to https://data.nextstrain.org/files/workflows/mpox/sequences.fasta.xz, etc... rather than
/files/workflows/monkeypox
. This may affect users who've been relying on the current URLs. Nothing should break for these users as the old files will continue to exist but they will no longer receive updated data. I think this is an okay trade-off in terms of downstream impacts.