-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/gcp/iam #230
Refactoring/gcp/iam #230
Conversation
The service seems to work fine but the resource counts have changed; In the previous implementation, IAM showed a count of 8 resources where as the new implementation shows 4 resources. In both cases, there are 4 service accounts, which is shown correctly in the top navigation bar for both implementations. I thought it might be due to the keys and bindings counts but they do not seem to be set, even in the previous implementation. |
The build doesn't pass for Python 3.5 because of formatted strings using the |
Well asyncio is available from 3.5+, but 3.6+ should be the standard 3.x on most distros. If there's a benefit to only supporting 3.6+ that's something we could consider. I'm seeing a lot of changes happening in python 3.x so if we're along for the ride (and everyone will have to be from 2020 onward) then we might as well just accept that having outdated versions of python is not acceptable anymore. |
I'm not sure formatted string literals is a good enough reason to deprecate 3.5... but at the same time, it seems like there's barely anyone using 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gg! Does it break the UI as well though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd just add a small comment in the parse thingy, otherwise, gg!
Migrated GCP's IAM service to the new architecture.
Note that
gcp/resources/projects.py
andgcp/facade/base.py
are the same as in the Stackdriver logging PR; they are simply shared by all services and will appear in all GCP refactoring PRs until one of the services is merged.