Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring/gcp/cloudsql #232

Merged
merged 34 commits into from
Apr 4, 2019
Merged

Refactoring/gcp/cloudsql #232

merged 34 commits into from
Apr 4, 2019

Conversation

Remi05
Copy link
Contributor

@Remi05 Remi05 commented Mar 7, 2019 •
edited
Loading

Migrated GCP's Cloud SQL service to the new architecture.

Note that gcp/resources/projects.py and gcp/facade/base.py are the same as in the Stackdriver logging PR and the IAM PR; they are simply shared by all services and will appear in all GCP refactoring PRs until one of the services is merged.

@Remi05 Remi05 requested review from x4v13r64, Aboisier and misg and removed request for x4v13r64 March 7, 2019 07:15
@Remi05 Remi05 self-assigned this Mar 7, 2019
@Remi05 Remi05 added this to the Iteration #4 milestone Mar 7, 2019
@codecov-io
Copy link

codecov-io commented Mar 7, 2019 •
edited
Loading

Codecov Report

Merging #232 into develop will increase coverage by 0.24%.
The diff coverage is 38.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
+ Coverage    34.92%   35.17%   +0.24%     
===========================================
  Files          170      174       +4     
  Lines         5663     5715      +52     
===========================================
+ Hits          1978     2010      +32     
- Misses        3685     3705      +20
Impacted Files Coverage Δ
...tSuite/providers/gcp/resources/cloudsql/backups.py 28.57% <28.57%> (ø)
...outSuite/providers/gcp/resources/cloudsql/users.py 35.29% <35.29%> (ø)
...iders/gcp/resources/cloudsql/database_instances.py 36.36% <36.36%> (ø)
ScoutSuite/providers/gcp/facade/cloudsql.py 40% <40%> (ø)
ScoutSuite/providers/gcp/configs/services.py 50% <50%> (ø) ⬆️
ScoutSuite/providers/gcp/facade/gcp.py 50% <50%> (ø) ⬆️
...tSuite/providers/gcp/resources/cloudsql/service.py 85.71% <85.71%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902fda0...51df33b. Read the comment docs.

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Mar 7, 2019

👏 👏 👏

@Aboisier Aboisier changed the base branch from refactoring/resource-configs to refactoring/gcp/stackdriverlogging March 7, 2019 13:04
@Aboisier Aboisier changed the base branch from refactoring/gcp/stackdriverlogging to refactoring/gcp-resource-configs March 7, 2019 13:05
@misg
Copy link
Contributor

misg commented Mar 7, 2019

Could you please merge with refactoring/gcp-resource-configs to avoid the 263 commits and 86 files changed (I can't do my review in those conditions, sorry 😭).

Aboisier
Aboisier suggested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because I guess the UI didn't like those changes either! Otherwise, good stuff!

@Remi05
Copy link
Contributor Author

Remi05 commented Apr 1, 2019 •
edited
Loading

Fixed UI and added left menu for projects.

Before :

cloudsql_before

After :

cloudsql_after

@Remi05 Remi05 changed the base branch from refactoring/resource-configs to develop April 2, 2019 00:07
@Remi05 Remi05 requested a review from Aboisier April 2, 2019 02:38
@Remi05 Remi05 changed the base branch from develop to refactoring/gcp/stackdriverlogging April 2, 2019 03:04
misg
misg approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Aboisier
Aboisier suggested changes Apr 2, 2019
View reviewed changes
ScoutSuite/providers/gcp/resources/cloudsql/backups.py
async def fetch_all(self):
raw_backups = await self.gcp_facade.cloudsql.get_backups(self.project_id, self.instance_name)
for raw_backup in raw_backups:
if raw_backup['status'] == 'SUCCESSFUL':
Copy link
Contributor

@Aboisier Aboisier Apr 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was like that before, but what about the failed backups? (should we add an issue)

Copy link
Contributor Author

@Remi05 Remi05 Apr 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess they are considered not to be relevant, but @j4v would know more!

And yes, it was indeed this way before!

@Remi05 Remi05 requested a review from Aboisier April 3, 2019 23:08
Aboisier
Aboisier reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w8

@Remi05 Remi05 changed the base branch from refactoring/gcp/stackdriverlogging to develop April 4, 2019 01:51
@Remi05 Remi05 merged commit 7eec287 into develop Apr 4, 2019
@Remi05 Remi05 deleted the refactoring/gcp/cloudsql branch April 4, 2019 02:05
@Aboisier Aboisier mentioned this pull request Apr 4, 2019
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aboisier Aboisier Aboisier approved these changes

@misg misg misg approved these changes

@x4v13r64 x4v13r64 Awaiting requested review from x4v13r64

Assignees

@Remi05 Remi05

Labels
component-provider-gcp Affects GCP provider providers-refactoring refactoring
Projects
None yet
Milestone
Iteration #4
Development

Successfully merging this pull request may close these issues.
5 participants
@Remi05 @codecov-io @x4v13r64 @misg @Aboisier