Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/gcp/stackdriverlogging #229

Merged
merged 49 commits into from
Apr 4, 2019

Conversation

Remi05
Copy link
Contributor

@Remi05 Remi05 commented Mar 7, 2019

Migrated GCP's Stackdriver logging service to the new architecture. Stackdriver logging is one of the simpler services for GCP and serves as a great proof of concept for the refactoring of the architecture for this provider.

@Remi05 Remi05 requested review from x4v13r64, Aboisier and misg March 7, 2019 02:06
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #229 into develop will increase coverage by 0.25%.
The diff coverage is 50.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #229      +/-   ##
===========================================
+ Coverage    34.43%   34.69%   +0.25%     
===========================================
  Files          159      166       +7     
  Lines         5549     5626      +77     
===========================================
+ Hits          1911     1952      +41     
- Misses        3638     3674      +36
Impacted Files Coverage Δ
...viders/gcp/resources/stackdriverlogging/service.py 100% <100%> (ø)
...roviders/gcp/resources/stackdriverlogging/sinks.py 35.29% <35.29%> (ø)
ScoutSuite/providers/gcp/resources/resources.py 44.44% <44.44%> (ø)
ScoutSuite/providers/gcp/facade/utils.py 46.15% <46.15%> (ø)
ScoutSuite/providers/gcp/resources/projects.py 46.66% <46.66%> (ø)
ScoutSuite/providers/gcp/configs/services.py 50% <50%> (ø) ⬆️
ScoutSuite/providers/gcp/facade/gcp.py 50% <50%> (ø)
ScoutSuite/providers/gcp/facade/base.py 58.33% <58.33%> (ø)
...utSuite/providers/gcp/facade/stackdriverlogging.py 66.66% <66.66%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e7c2c...31e109a. Read the comment docs.

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Mar 7, 2019

👏 👏 👏

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

@Remi05 Remi05 requested a review from misg April 2, 2019 02:38
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Apr 2, 2019

The three Xs next to Show all were carried over from the AWS Regions left menu. They can be removed if it was not a design choice.

I think that might be a bug (carried over from AWS)? Should be displaying the # of items.

Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, L(almost)GTM, because of the parallelization stuff.

@Remi05
Copy link
Contributor Author

Remi05 commented Apr 2, 2019

The three Xs next to Show all were carried over from the AWS Regions left menu. They can be removed if it was not a design choice.

I think that might be a bug (carried over from AWS)? Should be displaying the # of items.

I fixed it along with the AWS regions left menu!

@Remi05 Remi05 requested a review from Aboisier April 3, 2019 22:25
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing about the comment, but looks good otherwise.

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no wait actually

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure all good

@Remi05 Remi05 merged commit ba8bf3e into develop Apr 4, 2019
@Remi05 Remi05 deleted the refactoring/gcp/stackdriverlogging branch April 4, 2019 02:01
@Aboisier Aboisier mentioned this pull request Apr 4, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants