-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/gcp/stackdriverlogging #229
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #229 +/- ##
===========================================
+ Coverage 34.43% 34.69% +0.25%
===========================================
Files 159 166 +7
Lines 5549 5626 +77
===========================================
+ Hits 1911 1952 +41
- Misses 3638 3674 +36
Continue to review full report at Codecov.
|
👏 👏 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start!
ScoutSuite/providers/gcp/rules/findings/stackdriverlogging-no-export-sinks.json
Show resolved
Hide resolved
I think that might be a bug (carried over from AWS)? Should be displaying the # of items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, L(almost)GTM, because of the parallelization stuff.
I fixed it along with the AWS regions left menu! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing about the comment, but looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no wait actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sure all good
Migrated GCP's Stackdriver logging service to the new architecture. Stackdriver logging is one of the simpler services for GCP and serves as a great proof of concept for the refactoring of the architecture for this provider.